Re: libexcel-template-plus-perl
On Thu, 2012-05-03 at 08:42 -0400, Salvatore Bonaccorso wrote:
> On Thu, May 03, 2012 at 06:09:15AM -0400, Robert James Clay wrote:
> > I am working on getting Excel::Template::Plus into Debian as the
> > package libexcel-template-plus-perl. Salvatore Bonaccorso recently was
> > kind enough review my efforts so far and one of the things he noted was
> > as follows: "Missing dependencies on libmoose-perl".
> >
> > That's easy enough to do but I'm wondering if it still needs to be
> > listed explicitly when the (admittedly, new) package
> > libmoosex-param-perl, which also depends on it, is already listed?
>
> If I see it correctly, 'use Moose;' is used directly in the code,
It is.
> thus it needs a direct dependency. Assume (even unlikely)
> Excel::Template::Plus would drop the libmoosex-param-perl dependency,
> then when reevaluating the dependencies you would need anyway to add
> it back again.
True, and something I hadn't thought of.
> As 'basic rule': if a module is used directly in the code, then it
> also should be listed in dependency.
That explains it.
> Note: I only have done a 'git grep 'use Moose;' to check, but not if
> it is then actually used.
It looks like it is.
> Does this brings some clarification?
Indeed it does, thanks!
RJ Clay
jame@rocasa.us
Reply to: