Re: libauthen-radius-perl: Upgrade to version 0.14
Italo:
It's probably a lot easier to do this over IRC if you can join the channel...
What I meant by:
- The description should have "Authen::Radius" in it somewhere, so that
users can find it if they do: apt-cache search Authen::Radius
- The Description synopsis line should begin with a noun, so that you
can read it as: <pkg> is a <synopsis> (the short description). So,
something like: Perl module to authenticate users using RADIUS.
+ done
Was to change:
Description: Authen::Radius is a perl module to authenticate users using RADIUS
With this perl module you can check users and credentials against a
radius database, or you can change a user's settings.
To something like:
Description: Perl module to authenticate users using RADIUS
Authen::Radius is a Perl module you can use to check users and
credentials against a
radius database. It also allows one to change a user's settings.
(This way, you can read the first like line: libauthen-radius-perl IS
A.. Perl module to authenticate users using RADIUS)
* It looks like d/copyright is old, you should add yourself (and other
entries from d/copyright's trailing lines: grep debian/copyright
"\--") to the file for the debian/* section.
* d/compat is a file that shows the current debhelper major version
that the package corresponds to; in this case, we are using the 7.x
series of debhelper, so d/compat should contain the single number "7"
(instead of "5" as it currently does)
* Please remove the notes I made before you upload
Other than these few final things it looks good. It builds OK in a
chroot, which is certainly a very good sign :-)
After you make the above changes I suggest you run: dch -r, in the
main directory, remove my notes, and use 'debcommit' (or svn commit).
Then gregoa or another DD sponsor will pick it up and either make
additional notes or upload the package.
Thanks for your contribution! Hope this wasn't too difficult an
experience and that you've built up your confidence for working with
Debian Perl packages :-)
Cheers,
Jonathan
On Sun, Aug 30, 2009 at 12:02 AM, Italo Valcy<italo@dcc.ufba.br> wrote:
> Hi Jonathan,
>
> Citando Jonathan Yu <jonathan.i.yu@gmail.com>, em 29-08-2009:
>
>> I made some notes of things
>> you should take a look at to polish up the package some more; please
>> svn up and look at debian/changelog.
>
> Ok, thanks for the comments!!! I learned a lot of things to accomplish your
> tips/advices, realy thanks!
>
>
>> I have not yet tried actually
>> building the new version, so once you have made some of the changes
>> noted in the changelog, I'll try building in a chroot and do another
>> review.
>
> Please, take a look again and send me a feedback, ok? I'm wainting for a new
> review :)
>
>
> Kind regards, Italo.
>
> --
> Saudações,
>
> Italo Valcy :: http://wiki.dcc.ufba.br/~ItaloValcy
>
Reply to: