[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Minutes from the DPG meeting @DebConf9, 2009-07-18

On Sat, 18 Jul 2009 23:05:28 +0300, Damyan Ivanov wrote:

> unify d/repack
>  - Ryan52 is already working on this

And Ryan has already committed some repack* files to scripts/ -

At first sight they look nice, I have only one small wishlist
request, something like:

Index: repack.sh
--- repack.sh	(revision 40402)
+++ repack.sh	(working copy)
@@ -92,14 +92,13 @@
 ## End
 REPACK_DIR="$PKG-${VER}${SUFFIX}.orig" # DevRef §
 real_mv "$UP_BASE" "$DIR/$REPACK_DIR"
 # Using a pipe hides tar errors!
 tar cfC "$DIR/repacked.tar" "$DIR" "$REPACK_DIR"
 gzip -9 < "$DIR/repacked.tar" > "$DIR/repacked.tar.gz"
-real_mv "$DIR/repacked.tar.gz" "$DFSG_TAR"
+real_mv "$DIR/repacked.tar.gz" "$FILE"
+prename --verbose --force "s/$VER/${VER}${SUFFIX}/" $FILE
-echo "*** $DFSG_TAR ready"
+echo "*** $FILE repackaged"

I.e. instead of hardcoding ../new.tar.gz (and probably leaving the old
one around?) using the old file and renaming it -- which makes it
easier to use uscan's --destdir etc.

What do others think?

 .''`.   http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
   `-    BOFH excuse #369:  Virus transmitted from computer to sysadmins. 

Attachment: signature.asc
Description: Digital signature

Reply to: