[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: perl 5.8 questions/comments



On Tue, Jul 30, 2002 at 11:58:22PM -0400, Joey Hess wrote:
>I've uploaded my XS modules. I do have some odd problem with grepmail
>and perl 5.8; something to do with regexes.
>
>joey@dragon(chroot):~package/grepmail>./grepmail 
>Useless (?g) - use /g modifier in regex; marked by <-- HERE in m/(?mg <-- HERE x)^(From\s.*\d:\d\d:\d\d\s\d{4}|
>                                  From\s.*\d:\d\d:\d\d\s\d{4}\s[+-]\d{4}|
>                                  From\s.*\d:\d\d\s.*\w{2,3}\s\d{4})$/ at ./grepmail line 163.

(?g) has never been correct AFAIK, although it may have worked in the
past.  perlre(3perl) allows "(?imsx-imsx)".

Recall that such embedded modifiers affect the portion of the regular
expression which follows, up until the end or the next modifier.  /g
isn't really valid for part of a regex.

Easy fix:

  while($READ_BUFFER =~ m/^(From\s.*\d:\d\d:\d\d\s\d{4}|
			    From\s.*\d:\d\d:\d\d\s\d{4}\s[+-]\d{4}|
			    From\s.*\d:\d\d\s.*\w{2,3}\s\d{4})$/mgx)


>I will likey be building some of the modules causing the following:
>
>The following packages will be REMOVED:
>  apt-src frozen-bubble frozen-bubble-lib grepmail libapt-pkg-perl
>  libdigest-md5-perl libhtml-parser-perl libhtml-tree-perl libmime-base64-perl
>  libnet-perl libsdl-perl libterm-readline-gnu-perl libtime-hires-perl
>  libwww-perl 
>
>And will be happy to NMU them in if requested.

I'll be uploading libapt-pkg-perl sometime today.

Don't bother about libdigest-md5-perl, libmime-base64-perl, libnet-perl
or libtime-hires-perl as all of these are now part of perl.

Feel free to NMU anything else (if the maintainer objects I can always
remove the package from the staging area before dumping the rest into
incoming).

--bod



Reply to: