On Sun, Aug 27, 2017 at 05:46:40PM +0200, Rafael Laboissière wrote: > Sébastien Villemot <sebastien@debian.org> [2017-08-26 22:14]: > > My final concern is about the *.m files that are actually tested. If the > > source tree has not been built, then the test routines rightly test the > > files under /usr/share/octave. But if the source tree is built, then it > > tests files under debian/ (see the addpath in check-pkg). > > Actually, it tests now the *.m files under inst/, as in version 1.4.6 of > octave-pkg-dev (see my commit e3e12be). Anyway, this has no incidence on > the issue you are raising. The testsuite itself is indeed extracted from the *.m files under inst/, but this is not necessarily the case of the tested functions. The problem comes from this line in check-pkg: echo "addpath (genpath ([pwd(),'/debian']));" > $tmp This means that if any *.m file with the same name as a tested function is under the debian/ directory, it that file that will be tested, not the version installed under /usr/share/octave. Again, this is a problem only if the source tree has been built, otherwise there is no *.m file under debian/ (or maybe just check.m or something similar). -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ http://www.debian.org
Attachment:
signature.asc
Description: PGP signature