On Fri, Aug 25, 2017 at 09:14:44PM +0200, Rafael Laboissière wrote: > I have designed a very simple way of adding autopkgtest functionality to the > OF packages. You can try it with the following commands: > > sudo aptitude install octave-image > gbp clone https://anonscm.debian.org/git/pkg-octave/octave-image.git > cd octave-image > git checkout autopkgtest > autopkgtest -B . -- null > > Notice that you will need octave-pkg-dev >= 1.4.6 (now in unstable) for that > to work. > > This is implemented through the d/tests/control file: > > ##################################### > Tests: unit-tests > Depends: @, octave-pkg-dev (>= 1.4.6) > ##################################### > > and the d/tests/unit-tests file: > > ##################################### > #!/bin/sh > exec 2>&1 > set -e > debian/rules check-pkg > ##################################### > > Tell me what you think, please. I did not yet give a try to it, so I may have missed something, but are you sure that it catches test failures? When the unit tests are run at build time, failures are never fatal (we have to look at the build log to catch them), and my understanding is that the autopkgtest relies on the same codebase. If we want the autopkgtest to be useful, it should actually catch test failures through the appropriate exit code. -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ http://www.debian.org
Attachment:
signature.asc
Description: PGP signature