Nicolas Bourdaud <nicolas.bourdaud@gmail.com> writes: > On 27/05/2012 22:49, Sébastien Villemot wrote: >> Looks like the pristine-tar branch is not ok. When I do >> "git-buildpackage --git-pristine-tar", I get: >> >> fatal: Path 'mwrap_0.33.orig.tar.gz.delta' does not exist in 'refs/heads/pristine-tar' >> pristine-tar: git show refs/heads/pristine-tar:mwrap_0.33.orig.tar.gz.delta failed >> gbp:error: Couldn't checkout "mwrap_0.33.orig.tar.gz": /usr/bin/pristine-tar returned 128 >> >> Can you replicate the problem and, if yes, fix it? > > Yes, the problem has been reproduced and fixed. :-) I confirm this. >> Also I noticed that you changed the license for the packaging work in >> debian/copyright, but you only changed the license title to MIT without >> changing the rest of the paragraph. I would rather keep the packaging >> under the GPL, but if you want to have it under MIT license, then please >> fix the license paragraph. > > Actually, I did it after the suggestion of Yaroslav Halchenko. The > rationale was to make the patches mergeable in upstream. It is true that > it is necessary only for debian/patches/* but let's keep it simple. Ok this is fine with me. > The package should now be close to be ready. Yes indeed the package looks good. May I suggest one more improvement? It would be great to have the examples shipped under /usr/share/doc/mwrap/examples (see Policy §12.6 and dh_installexamples(1)). These examples are mentionned in the documentation, and they are of great value for a new user of the package. It’s up to you whether to ship or not the build system of the examples. Thanks for your work, -- Sébastien Villemot Researcher in Economics & Debian Maintainer http://www.dynare.org/sebastien Phone: +33-1-40-77-84-04 - GPG Key: 4096R/381A7594
Attachment:
pgp6HkqvUVBI7.pgp
Description: PGP signature