Re: [Caml-list] [ANNOUNCE] otags reloaded 3.12.1 for OCaml 3.12.1

[Hendrik Tews <tews@os.inf.tu-dresden.de>]

Hi,

the next otags package is available in mentors. It is now
otags_3.12.1.99-1, because I figured it does not make much sense
to have a Debian package 3.12.2 before I release 3.12.2 (which I
do as soon as the Debian package is ready).

I managed now to build the package from a git repository with
git-buildpackage. Shall I push my changes back to your otags git
repository or shall I wait a bit with that?


Stéphane Glondu <glondu@debian.org> writes:

   In prerm, you can factor both cases with "remove|upgrade)", cannot you?

Done.

   "debhelper (>= 7.2.11~)" is needed for "--with ocaml" support. Or,
   better, just bump to compat level 8.

When I use compat level 8 I get 

dh --with ocaml clean
dh: Unknown sequence --with (options should not come before the sequence)

immediately after git-buildpackage started. I therefore stay with
level 7 and adjusted the debhelper dependency.

   I would also keep "ocaml-nox (>= 3.11.1-3~)" since it goes with
   "dh-ocaml (>= 0.9~)", at least until Wheezy is released.

Done.

   Please remove the "cleaner=" line from gbp.conf. Use "unapply-patches"
   in debian/source/local-options instead (it should even not be needed any
   more with a recent version of dpkg-dev IIRC).

Done.

   Please avoid trailing whitespaces.

Done (I hope).


   > override_dh_gencontrol:
   >         dh_gencontrol -i -- -VF:OCamlABI="$(OCAMLABI)"

When I use dh_gencontrol -i I get 

dh_gencontrol -i -- -VF:OCamlABI="3.12.1"
dh_gencontrol: You asked that all arch in(dep) packages be built, but there are none of that type.

and building the package in pbuilder fails.

I therefore use now 

override_dh_gencontrol:
	dh_gencontrol -- -VF:OCamlABI="$(OCAMLABI)"

but where does OCAMLABI come from? I use now 

OCAMLABI:=$(shell ocamlc -version)

but this seems a bit too restrictive to me. Otags reads a
marshaled value from camlp4, I would expect this to work across
minor revisions, eg a marshaled value from camlp4 version 3.12.2
can be read from otags compiled with 3.12.1.


   Why do you disable the tests? It's better to run as much of them as
   possible... (unless DEB_BUILD_OPTIONS contains nocheck, but dh_auto_test
   should take care of that).

One of the tests uses the sexplib syntax extension. I would
therefore need libsexplib-camlp4-dev as build dependency. Further
with the current makefile the tests do only work when ocamlc.opt
is available. Could we postpone the tests until version 3.12.3?

   And I am still not convinced
   by your arguments about Build-Depends/configure checks for the ocaml
   version, but I won't go as far as to reject your package because of that.

I am optimistic about reaching an agreement here. But I would
suggest that we postpone this point for a while.


Bye,

Hendrik