[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023232: marked as done (samplv1 FTCBFS: strips with the build architecture strip)

Your message dated Fri, 30 Dec 2022 15:35:00 +0000
with message-id <E1pBHPQ-00B3uE-Kv@fasolo.debian.org>
and subject line Bug#1023232: fixed in samplv1 0.9.28-1
has caused the Debian Bug report #1023232,
regarding samplv1 FTCBFS: strips with the build architecture strip
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1023232: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023232
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: samplv1
Version: 0.9.27-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

samplv1 fails to cross build from source, because the upstream
CMakeLists.txt hard code the build architecture strip. Beyond breaking
cross compilation, this also breaks DEB_BUILD_OPTIONS=nostrip as well as
generation of -dbgsym packages. Please consider applying the attached
patch to fix all of the above.

Helmut

diff --minimal -Nru samplv1-0.9.27/debian/changelog samplv1-0.9.27/debian/changelog
--- samplv1-0.9.27/debian/changelog	2022-10-06 23:29:26.000000000 +0200
+++ samplv1-0.9.27/debian/changelog	2022-10-31 21:34:20.000000000 +0100
@@ -1,3 +1,10 @@
+samplv1 (0.9.27-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 31 Oct 2022 21:34:20 +0100
+
 samplv1 (0.9.27-1) unstable; urgency=medium
 
   * New upstream version 0.9.27
diff --minimal -Nru samplv1-0.9.27/debian/patches/cross.patch samplv1-0.9.27/debian/patches/cross.patch
--- samplv1-0.9.27/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ samplv1-0.9.27/debian/patches/cross.patch	2022-10-31 21:34:18.000000000 +0100
@@ -0,0 +1,39 @@
+--- samplv1-0.9.27.orig/CMakeLists.txt
++++ samplv1-0.9.27/CMakeLists.txt
+@@ -53,6 +53,7 @@
+ endif ()
+ 
+ set (CONFIG_PREFIX "${CMAKE_INSTALL_PREFIX}")
++set (CONFIG_STRIP "strip" CACHE STRING "Utility used for stripping objects")
+ 
+ include (GNUInstallDirs)
+ set (CONFIG_BINDIR  "${CONFIG_PREFIX}/${CMAKE_INSTALL_BINDIR}")
+--- samplv1-0.9.27.orig/src/CMakeLists.txt
++++ samplv1-0.9.27/src/CMakeLists.txt
+@@ -197,7 +197,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.so)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.so)
+     endif ()
+     if (CONFIG_PREFIX MATCHES $ENV{HOME})
+       set (CONFIG_LV2DIR ${CONFIG_PREFIX}/.lv2)
+@@ -216,7 +216,7 @@
+     target_link_options (${PROJECT_NAME}_lv2 PRIVATE -static-libgcc -static-libstdc++)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.dll)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.dll)
+     endif ()
+     set (CONFIG_LV2DIR ${CONFIG_WINDOWS_LV2_PATH})
+     install (FILES ${CMAKE_CURRENT_BINARY_DIR}/lib${PROJECT_NAME}_lv2.dll
+@@ -246,7 +246,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_jack POST_BUILD
+-        COMMAND strip ${PROJECT_NAME}_jack)
++        COMMAND ${CONFIG_STRIP} ${PROJECT_NAME}_jack)
+     endif ()
+     install (TARGETS ${PROJECT_NAME}_jack RUNTIME
+       DESTINATION ${CMAKE_INSTALL_BINDIR})
diff --minimal -Nru samplv1-0.9.27/debian/patches/series samplv1-0.9.27/debian/patches/series
--- samplv1-0.9.27/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ samplv1-0.9.27/debian/patches/series	2022-10-31 21:33:29.000000000 +0100
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru samplv1-0.9.27/debian/rules samplv1-0.9.27/debian/rules
--- samplv1-0.9.27/debian/rules	2022-10-06 11:05:05.000000000 +0200
+++ samplv1-0.9.27/debian/rules	2022-10-31 21:34:20.000000000 +0100
@@ -9,6 +9,7 @@
 else
  CMAKE_OPTS = -DCONFIG_ALSA_MIDI=OFF
 endif
+CMAKE_OPTS += -DCONFIG_STRIP=/bin/true
 
 %:
 	dh $@

--- End Message ---
--- Begin Message --- 
Source: samplv1
Source-Version: 0.9.28-1
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
samplv1, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1023232@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated samplv1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Dec 2022 16:13:12 +0100
Source: samplv1
Architecture: source
Version: 0.9.28-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 1023232
Changes:
 samplv1 (0.9.28-1) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #1023232)
 .
   [ Dennis Braun ]
   * New upstream version 0.9.28
   * Bump Standards-Version to 4.6.2
   * Change my email address
Checksums-Sha1:
 1132b3e51dd4881a70cada5fadb4d3884432efa6 2317 samplv1_0.9.28-1.dsc
 92b6c0caeb900c01c3a65e06be3142b80dc5ac94 281725 samplv1_0.9.28.orig.tar.gz
 8e861b81bf8d6abaf763a4fc79e9c718259eebda 6524 samplv1_0.9.28-1.debian.tar.xz
 c460e647c6dcade9ff330cdacdcc2c752b2bccb7 6726 samplv1_0.9.28-1_source.buildinfo
Checksums-Sha256:
 3498b3ce6dcc02129bbc2e840aa71fbcae408c5f8548da6819d441097dbeff94 2317 samplv1_0.9.28-1.dsc
 523186ae96c7b8c60e7d91cb92fa40298a889760f82c103cc34a00d34d2b236b 281725 samplv1_0.9.28.orig.tar.gz
 402e33353e7cbb490cfda5c4fb1f34b92500c44588d0f912129074eb36f0e0d6 6524 samplv1_0.9.28-1.debian.tar.xz
 2f602c30edfbd780b64cfa63f8e22af002ac353da24424f588b0d5e4328a1960 6726 samplv1_0.9.28-1_source.buildinfo
Files:
 31a3eed2d8b371342d76a02db29cc2f7 2317 sound optional samplv1_0.9.28-1.dsc
 6ebf836feb5ac17fe041f152a11f8acd 281725 sound optional samplv1_0.9.28.orig.tar.gz
 643c9f5eedeacac607017dc07f193276 6524 sound optional samplv1_0.9.28-1.debian.tar.xz
 17ae5d736694afd0d45dd3a02839c7c9 6726 sound optional samplv1_0.9.28-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmOvABkPHHNuZEBkZWJp
YW4ub3JnAAoJEGNOpV2QK5g2JjoP/iv1zbf8EKK9KDIsHP837wCWEKrrwRVygsRL
QxOBDStVJqiMZVCwIRqRVh9hj4V/XAZlrXz6wCL0l/4h0m4PUiu4cRe/QduX6WfG
hXeoYMmjv2PmzWUDqJQ33nhgfbNfVnwJOskNhEM6RXKsi1LEGNAt0+7e9riuSm2z
9jVeoecXzef/XW/aFDeFoteQRcxcBTXmpvQLfy+woIPiw/SGoHTYbWiszKb5GID7
79aq2hyqL0JB+0lIg2fjdJkjUCfndZ7hfEtWNAljpPRj2CFdwObuSDDUG7xgO0Ij
J3y1hmPX44NfE/o1O81rqu/0t53fvCM6hpe8EtwQyFFqex3OkRrJyQkJLMVdR3MB
q9pKFx09LL4XDO0QCwvjFoiu0/Tbbi0XSwHyuTz4SOWPw+u971+70mv0sKmIQjQX
P2AT4kRlbEkxOJAg1In/Vi6TL5vxbTQkcdGWb7wTY+GxoLa3HFfeAH46ezvTGW3F
qRQ6RH9IDFU7rwFgkkmRc5BHBnxhg+WsrtE3bQ1goFYjSIrZK5mWdltQxAOICfcv
oCcVb9qvZw1Bui4Bx9Ii+U1NsK4aiw4yBAVfKuHa4mlwrfIO6/RcltiZYkCWABZC
Y8kgXNv2wsjl7FKpfNwijJll480qQNAzqVi8OjpJ2KKYVXUPUPYSMqd5xyW6+EwU
yEFVrLtK
=nWEV
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: