[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023235: marked as done (synthv1 FTCBFS: strips with the build architecture strip)

Your message dated Fri, 30 Dec 2022 15:35:11 +0000
with message-id <E1pBHPb-00B3vp-0T@fasolo.debian.org>
and subject line Bug#1023235: fixed in synthv1 0.9.28-1
has caused the Debian Bug report #1023235,
regarding synthv1 FTCBFS: strips with the build architecture strip
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1023235: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023235
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: synthv1
Version: 0.9.24-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

synthv1 fails to cross build from source, because the upstream
CMakeLists.txt hard code the build architecture strip. Beyond breaking
cross compilation, this also breaks DEB_BUILD_OPTIONS=nostrip as well as
generation of -dbgsym packages. Please consider applying the attached
patch to fix all of the above.

Helmut

diff --minimal -Nru synthv1-0.9.27/debian/changelog synthv1-0.9.27/debian/changelog
--- synthv1-0.9.27/debian/changelog	2022-10-06 23:27:01.000000000 +0200
+++ synthv1-0.9.27/debian/changelog	2022-10-31 15:02:25.000000000 +0100
@@ -1,3 +1,10 @@
+synthv1 (0.9.27-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 31 Oct 2022 15:02:25 +0100
+
 synthv1 (0.9.27-1) unstable; urgency=medium
 
   * New upstream version 0.9.27
diff --minimal -Nru synthv1-0.9.27/debian/patches/cross.patch synthv1-0.9.27/debian/patches/cross.patch
--- synthv1-0.9.27/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ synthv1-0.9.27/debian/patches/cross.patch	2022-10-31 15:02:11.000000000 +0100
@@ -0,0 +1,39 @@
+--- synthv1-0.9.27.orig/CMakeLists.txt
++++ synthv1-0.9.27/CMakeLists.txt
+@@ -53,6 +53,7 @@
+ endif ()
+ 
+ set (CONFIG_PREFIX "${CMAKE_INSTALL_PREFIX}")
++set (CONFIG_STRIP "strip" CACHE STRING "Utility used for stripping objects")
+ 
+ include (GNUInstallDirs)
+ set (CONFIG_BINDIR  "${CONFIG_PREFIX}/${CMAKE_INSTALL_BINDIR}")
+--- synthv1-0.9.27.orig/src/CMakeLists.txt
++++ synthv1-0.9.27/src/CMakeLists.txt
+@@ -174,7 +174,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.so)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.so)
+     endif ()
+     if (CONFIG_PREFIX MATCHES $ENV{HOME})
+       set (CONFIG_LV2DIR ${CONFIG_PREFIX}/.lv2)
+@@ -193,7 +193,7 @@
+     target_link_options (${PROJECT_NAME}_lv2 PRIVATE -static-libgcc -static-libstdc++)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.dll)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.dll)
+     endif ()
+     set (CONFIG_LV2DIR ${CONFIG_WINDOWS_LV2_PATH})
+     install (FILES ${CMAKE_CURRENT_BINARY_DIR}/lib${PROJECT_NAME}_lv2.dll
+@@ -223,7 +223,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_jack POST_BUILD
+-        COMMAND strip ${PROJECT_NAME}_jack)
++        COMMAND ${CONFIG_STRIP} ${PROJECT_NAME}_jack)
+     endif ()
+     install (TARGETS ${PROJECT_NAME}_jack RUNTIME
+       DESTINATION ${CMAKE_INSTALL_BINDIR})
diff --minimal -Nru synthv1-0.9.27/debian/patches/series synthv1-0.9.27/debian/patches/series
--- synthv1-0.9.27/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ synthv1-0.9.27/debian/patches/series	2022-10-31 15:01:34.000000000 +0100
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru synthv1-0.9.27/debian/rules synthv1-0.9.27/debian/rules
--- synthv1-0.9.27/debian/rules	2022-10-06 11:05:29.000000000 +0200
+++ synthv1-0.9.27/debian/rules	2022-10-31 15:02:23.000000000 +0100
@@ -9,6 +9,7 @@
 else
  CMAKE_OPTS = -DCONFIG_ALSA_MIDI=OFF
 endif
+CMAKE_OPTS += -DCONFIG_STRIP=/bin/true
 
 %:
 	dh $@

--- End Message ---
--- Begin Message --- 
Source: synthv1
Source-Version: 0.9.28-1
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
synthv1, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1023235@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated synthv1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Dec 2022 16:13:33 +0100
Source: synthv1
Architecture: source
Version: 0.9.28-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 1023235
Changes:
 synthv1 (0.9.28-1) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #1023235)
 .
   [ Dennis Braun ]
   * New upstream version 0.9.28
   * Change my email address
   * Bump Standards Version to 4.6.2
Checksums-Sha1:
 080c733cddcfde7bb70589f5e347f1b545ce67cd 2317 synthv1_0.9.28-1.dsc
 2b965c3a611d8dc72499f4bec49bda3363233ea2 243778 synthv1_0.9.28.orig.tar.gz
 4bb1a9e54a469fd43de33610f4dba458e3684bb7 6456 synthv1_0.9.28-1.debian.tar.xz
 81d760d2cdc90e14fd621b1b2090a95fa8cc8136 6726 synthv1_0.9.28-1_source.buildinfo
Checksums-Sha256:
 eaf0932ef27f124cd8e7931230d8c1a61bc7044ee16afebc1b4f7bf4c57f21e3 2317 synthv1_0.9.28-1.dsc
 f31aee24446a23e0e5ba2184e797b1022b11582534703c3e297a6b9f701de14b 243778 synthv1_0.9.28.orig.tar.gz
 ad24340ac96b32297730dd978d9926e7677add202d30450c18b7a52f225fed19 6456 synthv1_0.9.28-1.debian.tar.xz
 15be9b2a6aa05175e2ed82ca81068cfbcc4db911941c75764b1d5316bf21f24f 6726 synthv1_0.9.28-1_source.buildinfo
Files:
 8454eb3110ce6462cb420d692bf83913 2317 sound optional synthv1_0.9.28-1.dsc
 934011dcbf2016f7b003d03485827938 243778 sound optional synthv1_0.9.28.orig.tar.gz
 9562fb46a722f0f55956c31b6fbbc5c5 6456 sound optional synthv1_0.9.28-1.debian.tar.xz
 f61bb38235198554fc2e4f42a6ee46b7 6726 sound optional synthv1_0.9.28-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmOvADMPHHNuZEBkZWJp
YW4ub3JnAAoJEGNOpV2QK5g2ArIP/1Ngun5+IIE5nfERn7e6WoNRZLw+n/NV2AYj
K9d0Vr+ggf0yVhIzTct07dOxX6NSxD0zAUrwjCcZcjKxx3kaDVyHZJpS2UkJPab3
D2CgykjN+S85vCSB1GVyHm4jfKH4cpE4duzl6S6ltbTRQ3SSC3aNzoFFT3DWdJOM
D0QwdLGVpYaRV2VHiXnM9xBBfkvmOHByZgMTzHtuqYtAON8N7emg8EKZtMpISkMO
pdVPRz5BZnVCd0l4YQA2fmicj0+ixP8IzEkSkEA4b/T0PJX0RYyqaiuEGDLAbz/i
YzRC011WAUpnV7OPUIg4XpOT6IkijyzuFSkYf09CsCjpFJUDN3irJjViOPNWJki3
Qwd5ekpgPuZrnarGzdqBPFU0zw47LPKF2+tFA4RJymx0OjGkg4Vx0iaF/AlkRWMM
TU2Edk8lOmARskuBRmqcrc95Wq7m85XoLGRyEx4iyq0o5J/vbxT3itKxRBX5ndI7
J7BlCdTfbyX1k8gXiRoB9mYRh579H+1ITw1OkQHNz0lPLXSbTUiIFt83K2U/U5FO
WhibXcnw2C7GBViezUJ2CWS0mntf+gQnv/Qy58n5+9J6pQ6JJYDLCvuN8HsUooSi
G+/y5PzJN5X5eWwn9bYiSn22014+Rqv1gpSi/mcL+H/+mdns175vLwSdjfVucByy
Xlwr76DC
=VeDm
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: