[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023232: marked as done (samplv1 FTCBFS: strips with the build architecture strip)

Your message dated Fri, 30 Dec 2022 15:34:50 +0000
with message-id <E1pBHPG-00B3sp-Pv@fasolo.debian.org>
and subject line Bug#1023232: fixed in padthv1 0.9.28-1
has caused the Debian Bug report #1023232,
regarding samplv1 FTCBFS: strips with the build architecture strip
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1023232: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023232
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: samplv1
Version: 0.9.27-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

samplv1 fails to cross build from source, because the upstream
CMakeLists.txt hard code the build architecture strip. Beyond breaking
cross compilation, this also breaks DEB_BUILD_OPTIONS=nostrip as well as
generation of -dbgsym packages. Please consider applying the attached
patch to fix all of the above.

Helmut

diff --minimal -Nru samplv1-0.9.27/debian/changelog samplv1-0.9.27/debian/changelog
--- samplv1-0.9.27/debian/changelog	2022-10-06 23:29:26.000000000 +0200
+++ samplv1-0.9.27/debian/changelog	2022-10-31 21:34:20.000000000 +0100
@@ -1,3 +1,10 @@
+samplv1 (0.9.27-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 31 Oct 2022 21:34:20 +0100
+
 samplv1 (0.9.27-1) unstable; urgency=medium
 
   * New upstream version 0.9.27
diff --minimal -Nru samplv1-0.9.27/debian/patches/cross.patch samplv1-0.9.27/debian/patches/cross.patch
--- samplv1-0.9.27/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ samplv1-0.9.27/debian/patches/cross.patch	2022-10-31 21:34:18.000000000 +0100
@@ -0,0 +1,39 @@
+--- samplv1-0.9.27.orig/CMakeLists.txt
++++ samplv1-0.9.27/CMakeLists.txt
+@@ -53,6 +53,7 @@
+ endif ()
+ 
+ set (CONFIG_PREFIX "${CMAKE_INSTALL_PREFIX}")
++set (CONFIG_STRIP "strip" CACHE STRING "Utility used for stripping objects")
+ 
+ include (GNUInstallDirs)
+ set (CONFIG_BINDIR  "${CONFIG_PREFIX}/${CMAKE_INSTALL_BINDIR}")
+--- samplv1-0.9.27.orig/src/CMakeLists.txt
++++ samplv1-0.9.27/src/CMakeLists.txt
+@@ -197,7 +197,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.so)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.so)
+     endif ()
+     if (CONFIG_PREFIX MATCHES $ENV{HOME})
+       set (CONFIG_LV2DIR ${CONFIG_PREFIX}/.lv2)
+@@ -216,7 +216,7 @@
+     target_link_options (${PROJECT_NAME}_lv2 PRIVATE -static-libgcc -static-libstdc++)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.dll)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.dll)
+     endif ()
+     set (CONFIG_LV2DIR ${CONFIG_WINDOWS_LV2_PATH})
+     install (FILES ${CMAKE_CURRENT_BINARY_DIR}/lib${PROJECT_NAME}_lv2.dll
+@@ -246,7 +246,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_jack POST_BUILD
+-        COMMAND strip ${PROJECT_NAME}_jack)
++        COMMAND ${CONFIG_STRIP} ${PROJECT_NAME}_jack)
+     endif ()
+     install (TARGETS ${PROJECT_NAME}_jack RUNTIME
+       DESTINATION ${CMAKE_INSTALL_BINDIR})
diff --minimal -Nru samplv1-0.9.27/debian/patches/series samplv1-0.9.27/debian/patches/series
--- samplv1-0.9.27/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ samplv1-0.9.27/debian/patches/series	2022-10-31 21:33:29.000000000 +0100
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru samplv1-0.9.27/debian/rules samplv1-0.9.27/debian/rules
--- samplv1-0.9.27/debian/rules	2022-10-06 11:05:05.000000000 +0200
+++ samplv1-0.9.27/debian/rules	2022-10-31 21:34:20.000000000 +0100
@@ -9,6 +9,7 @@
 else
  CMAKE_OPTS = -DCONFIG_ALSA_MIDI=OFF
 endif
+CMAKE_OPTS += -DCONFIG_STRIP=/bin/true
 
 %:
 	dh $@

--- End Message ---
--- Begin Message --- 
Source: padthv1
Source-Version: 0.9.28-1
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
padthv1, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1023232@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated padthv1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Dec 2022 16:11:44 +0100
Source: padthv1
Architecture: source
Version: 0.9.28-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 1023232
Changes:
 padthv1 (0.9.28-1) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Defer stripping to dh_strip. (Closes: #1023232)
 .
   [ Dennis Braun ]
   * New upstream version 0.9.28
   * Change my email address
   * Bump Standards-Version to 4.6.2
Checksums-Sha1:
 4bf09951dbf56f1e37dfe8ba0e2ad67e7f9537a4 2293 padthv1_0.9.28-1.dsc
 b07753f829de32d4e3ea644cddd443e00fb8c199 250223 padthv1_0.9.28.orig.tar.gz
 36b87d4dc434a3131ca3f8eb4e2df5d10c21d225 5996 padthv1_0.9.28-1.debian.tar.xz
 be5684cbf90620db77796c492aa91675bd1609cf 6726 padthv1_0.9.28-1_source.buildinfo
Checksums-Sha256:
 f398d46db6fd25c3b8af566033726d8f4083d2042d902d0f78e89fa24b776a02 2293 padthv1_0.9.28-1.dsc
 9c6e718cc191e34e27f9d595eb384271316e8e0fdeff891e762e4f2580c8c41a 250223 padthv1_0.9.28.orig.tar.gz
 dfe800f9e355a2d94f70f722fdd5f855b50c04f2b8f9246254e05339d7422462 5996 padthv1_0.9.28-1.debian.tar.xz
 b154d38cb6c72d743e2b94f4a129c709c6d6781526990f497590c1fe11616247 6726 padthv1_0.9.28-1_source.buildinfo
Files:
 f5914c9f0b344616879064cb9115aeae 2293 sound optional padthv1_0.9.28-1.dsc
 57995ac9eb5bf2c55742445b20347e59 250223 sound optional padthv1_0.9.28.orig.tar.gz
 0d008862b8918f93c7ba5230ccd411e7 5996 sound optional padthv1_0.9.28-1.debian.tar.xz
 50f144e0c317077849aff7e0ce8b05f2 6726 sound optional padthv1_0.9.28-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmOu/9YPHHNuZEBkZWJp
YW4ub3JnAAoJEGNOpV2QK5g2Cd8P/00xIeYrByypMEeOIEmwFpw0tb+kEpjgyLN6
P/LVCj7Wp//Rpq8MtsmnJBR4XNBQDtizQAX2oiM7Ec+U1keeE7rGXSRb0WtDI4Ob
MgwdtpSun2krVpR/je31+1V3j8gROWqCi9V7K+F/cM9yVCr7tSSNo7eLbu3DnnqG
BgkskBNRssVjniLe3HwJA+QQ0rb3hqlfNOezKHoMPmgWaxpX4GVpaDR3dOdkKncC
X3liZOF3+aVgaJn5MvMGGZfP6nRYbZDhNLOJviUDO/n4y3hIhglz/ndOkVc71SX8
Z4E/zCIalVNGmGCEiOYKxY8c47MgznLS6/e/+I+YhRpq0a13R5+52EsO66mWW7V5
fkABXoVXvmQPa06ed8xMWEZRkS6TCfCTNLtIoXpcRBRGQx9WTsUHIZqaRm4JhLyc
56bfLh7cyoT5lT2ikfuio6K6ahYJRcgkHsmYlionyRhcW6wWhzqgVrjvHwrt7/iI
cdzswt1ZUogIQStcQuKBybbEteISSm1GAmU/MEIEd7gh3jzSqEgJAV6cGMc4AmTe
5Fz7jRkEukIm+myOFhUGRw2Lj40Q8EsJnMrlzEZ2+mQxeCPq1OkCo02+LpDw81ZM
bjeqHM5qaL0RsxGO6TCIS6gFOQU8C2i5WuAiEQHCg1P1wA70E9FE6b4SlJgOOkT7
hi11XYzp
=tUyA
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: