[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023189: marked as done (drumkv1 FTCBFS: strips using the build architecture strip)

Your message dated Fri, 30 Dec 2022 15:34:08 +0000
with message-id <E1pBHOa-00B3pG-2I@fasolo.debian.org>
and subject line Bug#1023189: fixed in drumkv1 0.9.28-1
has caused the Debian Bug report #1023189,
regarding drumkv1 FTCBFS: strips using the build architecture strip
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1023189: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023189
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: drumkv1
Version: 0.9.24-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

drumkv1 fails to cross build from source, because it strips using the
build architecture strip. Beyond breaking cross compilation, this also
breaks DEB_BUILD_OPTIONS=nostrip as well as generation of -dbgsym
packages. Please consider applying the attached patch to fix all of the
above.

Helmut

diff --minimal -Nru drumkv1-0.9.27/debian/changelog drumkv1-0.9.27/debian/changelog
--- drumkv1-0.9.27/debian/changelog	2022-10-06 22:33:32.000000000 +0200
+++ drumkv1-0.9.27/debian/changelog	2022-10-31 11:43:38.000000000 +0100
@@ -1,3 +1,10 @@
+drumkv1 (0.9.27-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 31 Oct 2022 11:43:38 +0100
+
 drumkv1 (0.9.27-2) unstable; urgency=medium
 
   * Build with Qt6
diff --minimal -Nru drumkv1-0.9.27/debian/patches/nostrip.patch drumkv1-0.9.27/debian/patches/nostrip.patch
--- drumkv1-0.9.27/debian/patches/nostrip.patch	1970-01-01 01:00:00.000000000 +0100
+++ drumkv1-0.9.27/debian/patches/nostrip.patch	2022-10-31 11:43:38.000000000 +0100
@@ -0,0 +1,39 @@
+--- drumkv1-0.9.27.orig/CMakeLists.txt
++++ drumkv1-0.9.27/CMakeLists.txt
+@@ -53,6 +53,7 @@
+ endif ()
+ 
+ set (CONFIG_PREFIX "${CMAKE_INSTALL_PREFIX}")
++set (CONFIG_STRIP "strip" CACHE STRING "Utility used for stripping objects")
+ 
+ include (GNUInstallDirs)
+ set (CONFIG_BINDIR  "${CONFIG_PREFIX}/${CMAKE_INSTALL_BINDIR}")
+--- drumkv1-0.9.27.orig/src/CMakeLists.txt
++++ drumkv1-0.9.27/src/CMakeLists.txt
+@@ -189,7 +189,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.so)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.so)
+     endif ()
+     if (CONFIG_PREFIX MATCHES $ENV{HOME})
+       set (CONFIG_LV2DIR ${CONFIG_PREFIX}/.lv2)
+@@ -208,7 +208,7 @@
+     target_link_options (${PROJECT_NAME}_lv2 PRIVATE -static-libgcc -static-libstdc++)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_lv2  POST_BUILD
+-        COMMAND strip lib${PROJECT_NAME}_lv2.dll)
++        COMMAND ${CONFIG_STRIP} lib${PROJECT_NAME}_lv2.dll)
+     endif ()
+     set (CONFIG_LV2DIR ${CONFIG_WINDOWS_LV2_PATH})
+     install (FILES ${CMAKE_CURRENT_BINARY_DIR}/lib${PROJECT_NAME}_lv2.dll
+@@ -238,7 +238,7 @@
+   if (UNIX AND NOT APPLE)
+     if (NOT CONFIG_DEBUG)
+       add_custom_command(TARGET ${PROJECT_NAME}_jack POST_BUILD
+-        COMMAND strip ${PROJECT_NAME}_jack)
++        COMMAND ${CONFIG_STRIP} ${PROJECT_NAME}_jack)
+     endif ()
+     install (TARGETS ${PROJECT_NAME}_jack RUNTIME
+       DESTINATION ${CMAKE_INSTALL_BINDIR})
diff --minimal -Nru drumkv1-0.9.27/debian/patches/series drumkv1-0.9.27/debian/patches/series
--- drumkv1-0.9.27/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ drumkv1-0.9.27/debian/patches/series	2022-10-31 11:41:32.000000000 +0100
@@ -0,0 +1 @@
+nostrip.patch
diff --minimal -Nru drumkv1-0.9.27/debian/rules drumkv1-0.9.27/debian/rules
--- drumkv1-0.9.27/debian/rules	2022-10-06 21:45:24.000000000 +0200
+++ drumkv1-0.9.27/debian/rules	2022-10-31 11:43:38.000000000 +0100
@@ -9,6 +9,7 @@
 else
  CMAKE_OPTS = -DCONFIG_ALSA_MIDI=OFF
 endif
+CMAKE_OPTS += -DCONFIG_STRIP=/bin/true
 
 %:
 	dh $@

--- End Message ---
--- Begin Message --- 
Source: drumkv1
Source-Version: 0.9.28-1
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
drumkv1, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1023189@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated drumkv1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Dec 2022 16:10:48 +0100
Source: drumkv1
Architecture: source
Version: 0.9.28-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 1023189
Changes:
 drumkv1 (0.9.28-1) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #1023189)
 .
   [ Dennis Braun ]
   * New upstream version 0.9.28
   * Update my email address
   * Bump Standards-Version to 4.6.2
Checksums-Sha1:
 70a70e7658e41305776b023f54dc32d8d720657e 2336 drumkv1_0.9.28-1.dsc
 fe5b726d767f99d210d0dd239f1d864a381789fe 300051 drumkv1_0.9.28.orig.tar.gz
 73d8249962741f8d7b62c87afd1ec65a86c54edb 8052 drumkv1_0.9.28-1.debian.tar.xz
 0a657b1b1aec780ce53fa05feac0c677c6bd6bc6 6726 drumkv1_0.9.28-1_source.buildinfo
Checksums-Sha256:
 a7b209610238a7bf8a3aa513193b2dd616e1c02650e4c4d0a0d34afddb300808 2336 drumkv1_0.9.28-1.dsc
 0e9acc4e0bb6a0b49b5310dd3ddb047828fc26063bcd5845477dcd43ff766d3b 300051 drumkv1_0.9.28.orig.tar.gz
 3d942313fcf1fd07b756c44d22d7cd4da948590cf5841155740053e0e5012ad0 8052 drumkv1_0.9.28-1.debian.tar.xz
 d15697ce521f3bdfa025efe69f698540a5279cf04a436ce3b03e8ce923b68e1c 6726 drumkv1_0.9.28-1_source.buildinfo
Files:
 88497017bf3af1ef7ef6ef748b1002ec 2336 sound optional drumkv1_0.9.28-1.dsc
 ec5176c2cbdee5280f0629f95f9883b4 300051 sound optional drumkv1_0.9.28.orig.tar.gz
 c9f78e2fa654df38a5610b751b768f26 8052 sound optional drumkv1_0.9.28-1.debian.tar.xz
 e7976250bb8d909d9e48260a1ab05144 6726 sound optional drumkv1_0.9.28-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmOu/5cPHHNuZEBkZWJp
YW4ub3JnAAoJEGNOpV2QK5g2x/0QAMkclDluXUu5V4ZKxvzIwN4GHanzFPdSlIbG
aEk2H0BEx/dDQN4Qg9ehf88t5vDxcrn5XRQg+CKmYGamkho17f5d2gR6LkJoRJNB
8KyBnSDoxVHsVTFot3XuLvxp+SkrBtVxsQHax6Hko63xrmUT0wWkskbAvHYUYnzG
cYNjQ0jt+GzHt7wz3aTMvxrmnA/fAhOqHTqTCI/U6DZzce/UsrXOQtFL1I0tBl/+
IyOCOVZVlSO1gjoClDmZat9uOUmqoZwJkB3ZG9+9h2FcQPAvqYO3FFHaLBftySOF
L4AwsLrvr8ksodg5rOhUyr5ot/fV3ChxTmP5MZ+M4h6NWp8wc+DIIGkZb1/12pgC
GOQDRmf/AASORYLaGfH4OlLPcEYzbUnFHI48AWykH9W7ghYEWL7UznoRyEitI9Qh
Jryc0HeVT1t5ugoGVkjzgEfjPRTv3y0YM0chmwjJ7i+82MVMRgAboaZvpDZyfby7
625ytgF5HiRyllK15Q4CBFoqIQcaodaeA5rylt0vfXMHAboFJJrbPMonmFSPIKsc
XaDuWzni8j4xd8u4e3iv/ZKkbMdBLw+DUopNkJq+ihCpKsUoCRFhX1HDoMjUAO7U
slhiLbqjBjSGDVChooB1c7KR5GknYZVao2X50c7F0MNC/HX03i2Yc+xDjEQ3oCVa
ItolE3LW
=9mmJ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: