Re: Request for review and sponsoring for shotdetect 1.0.86-6

[Giulio Paci <giuliopaci@gmail.com>]

Hi Sebastian,
   I updated the package according to your feedback. Can you check
and, if everything seems in order, upload the package?

On Sat, Sep 11, 2021 at 8:40 AM Giulio Paci <giuliopaci@gmail.com> wrote:
> Il ven 10 set 2021, 22:27 Sebastian Ramacher <sramacher@debian.org> ha scritto:
>> On 2021-09-02 19:16:06 +0200, Giulio Paci wrote:
>> >    I am looking for someone to review (and hopefully upload)
>> > shotdetect 1.0.86-6.
>> >
>> > You can find the source of the package at:
>> > https://salsa.debian.org/multimedia-team/shotdetect/
>>
>> lintian reports:
>>
>> W: shotdetect source: no-versioned-debhelper-prerequisite 10
>> W: shotdetect source: patch-file-present-but-not-mentioned-in-series 1005-add_framenumber_to_filename.patch
>> W: shotdetect source: patch-file-present-but-not-mentioned-in-series 1006-label_xaxis_with_timecode.patch
>> W: shotdetect source: useless-autoreconf-build-depends autotools-dev
>> W: shotdetect source: useless-autoreconf-build-depends dh-autoreconf

All these warnings are gone now.

>> For the others: are the patches supposed to be used? If
>> not, please consider removing them.

It would be nice to use them, but I do not think they can be enabled
as-is. I contacted the author of the patches and asked to improve
them.
In the meanwhile I dropped them.

>> At this point, there is a lot of cdbs boilerplate in debian/rules. A
>> dh-based rules file with compat 13 would probably be a simple
>>
>> %:
>>   dh $@

I migrated to dh and compat 13 as suggested.

>> If you use dh-autoreconf,
>> autotools-dev is useless. debhelper depends on dh-autoreconf long enough
>> (at least since version 10, IIRC).
>> Furthemore, the BD on dpkg-dev (>= 1.16.1~) is satisfied in all
>> supported releases and can be removed.

I removed a bunch of useless dependencies.


Thank you for your support.

Cheers,
Giulio