[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for review and sponsoring for shotdetect 1.0.86-6



Hi Giulio

On 2021-09-02 19:16:06 +0200, Giulio Paci wrote:
> Dear team,
>    I am looking for someone to review (and hopefully upload)
> shotdetect 1.0.86-6.
> 
> You can find the source of the package at:
> https://salsa.debian.org/multimedia-team/shotdetect/

lintian reports:

W: shotdetect source: no-versioned-debhelper-prerequisite 10
W: shotdetect source: patch-file-present-but-not-mentioned-in-series 1005-add_framenumber_to_filename.patch
W: shotdetect source: patch-file-present-but-not-mentioned-in-series 1006-label_xaxis_with_timecode.patch
W: shotdetect source: useless-autoreconf-build-depends autotools-dev
W: shotdetect source: useless-autoreconf-build-depends dh-autoreconf

I think the first one is a bug in lintian (debhelper 10 is in
oldoldstable). For the others: are the patches supposed to be used? If
not, please consider removing them. If you use dh-autoreconf,
autotools-dev is useless. debhelper depends on dh-autoreconf long enough
(at least since version 10, IIRC).

Furthemore, the BD on dpkg-dev (>= 1.16.1~) is satisfied in all
supported releases and can be removed.

At this point, there is a lot of cdbs boilerplate in debian/rules. A
dh-based rules file with compat 13 would probably be a simple

%:
  dh $@

Cheers

> 
> This version closes bugs #993467 and #963965) and updates the
> packaging in general.
> I have not updated the watch file yet, since I am not able to find
> packaged sources from upstream anymore.
> 
> Below is the changelog entry for this version:
> 
> shotdetect (1.0.86-6) unstable; urgency=medium
> 
>   [ Ondřej Nový ]
>   * d/copyright: Use https protocol in Format field.
>   * d/control: Set Vcs-* to salsa.debian.org.
> 
>   [ Felipe Sateler ]
>   * Change maintainer address to debian-multimedia@lists.debian.org.
> 
>   [ Giulio Paci ]
>   * d/control: Update Homepage (Closes: #963965).
>   * d/control: Set Rules-Requires-Root to no.
>   * d/control: Add pkg-config build dependency.
>   * d/copyright: Update Source and Upstream-Contact.
>   * d/copyright: Remove file sections related to debian/* and autotools.
>   * d/compat: Bump compat level to 10.
>   * Add 1009-fix_missing_return_statement.patch (Closes: #993467).
>   * Add 1010-update_autotools_files.patch.
>   * Remove trailing space from 1008-fix-FTBFS-ffmpeg_2.9.patch.
>   * Add header to libav10.patch.
>   * d/rules: Enable autoreconf.
>   * d/rules: Avoid license checks of automatically generated files.
>   * d/rules: Backup and restore some files during building and clean targets.
>   * d/rules: Drop unnecessary DEB_CONFIGURE_SCRIPT_ENV.
>   * d/rules: Set empty DEB_INSTALL_CHANGELOGS_ALL in rules.
>     Prevent installation of empty upstream changelog.
>   * Refresh copyright_hints.
>   * Bump Standards-Version to 4.6.0.
>     No further changes needed.
> 
>  -- Giulio Paci <giuliopaci@gmail.com>  Tue, 31 Aug 2021 17:03:40 +0200
> 
> Best regards,
> Giulio
> 

-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


Reply to: