Re: ...delo getting me frustrated :-)

[Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>]

Herbert Valerio Riedel wrote:
[snip]
> > > alas your version had some ext2fs trouble (and I had to make the code
> > > ignore negative bootinit() retvals); 
> > 
> > What trouble specifically?
> 
> the ext2fs returned an error when trying to load the delo.conf..
> 
> it was
> ec      EXT2_ET_SHORT_READ,
>         "Attempt to read block from filesystem resulted in short read"
> iirc...
> 
> I thought it had to do w/ delo_read's logic...

This would be very strange, as delo_read doesn't use any ext2 functions.

[snip]
> > Can you can provide a patch between 0.7 and your version without the
> > seemingly ident-related clutter? I would like to include the relevant
> > parts in my version.
> 
> your code already does the right thing... (except for the disk I/O
> maybe, there seems to be some bug...

For now I guess it will work if bootinit's return value isn't checked.
At least, it works fine on my 5000/50. :-)

> btw, while at it, maybe grub's fs
> code might be interesting...)
> 
> I did just replaced the code in copyelf.c with something corresponding
> to your your ELF handling in loadelf.c, and pulled bootinit() into
> main(); and some other minor stuff I added while debugging delo...
> 
> sorry for indenting; (btw, you'd just have had to run 'indent' on
> delo-0.7 and diff against it):
> http://www.ifs.tuwien.ac.at/~hvr/linux-mipsel/delo-0.7indent-0.7hvr.diff

Thanks.

> ...lemme know when I can test/try out a new version of yours :-)

I'll do so, it may take a few days, though.


Thiemo