On Mon, Jun 01, 2020 at 01:39:10PM +0000, Vasyl Gello wrote:
> >* d/control:
> > + Vcs-* have to point to the packaging repository, not the upstream
> > one. Since this is something maintained by the multimedia team
> > (according to Maintainer) it should have a repo within the multimedia
> > team space.
>
> Fixed by setting Maintainer to me until I get into the team. I have not even raised
> the application intent yet.
Mhh, would you please instead consider joining it now, rather than move
stuff around later? I don't think I saw your joining mail in the last
20 days (sorry for ghosting - I had some personal matters going on).
> >* libudfread-dev.install
> > + you are installing the .a file: do you really need it? As a personal
> > policy I try to remove static libraries rather than adding them…
>
> I often link software statically, especially targeting Android.
> So I guess keeping static library won't hurt as part of -dev
> package.
I see that you removed it following pabs' suggestion. Well, just know
that whilst I generally agree with him that static libraries are usually
just an old renmant and they should be avoided, I also consider them
alright if somebody really need them (as long as they are not used to
statically link stuff within the archive).
Then, I notice that you are bumping the version while uploading to
mentors. In the end we shall only upload a -1 with only one changelog
entry to the archive, so feel free to just remove and re-upload the -1
version to mentors (IIRC you can also just re-upload the same version
and it would overwrite it).
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature