[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature

Hi Boyuan,

Thank you for your advice. I have fixed all issues you said. Please
see the comments below.

On Tue, May 5, 2020 at 11:37 AM Boyuan Yang <byang@debian.org> wrote:
> The members of salsa.debian.org/debian group are limited to DDs (Debian
> Developers). However, it is possible to add you as the maintainer of
> individual repos under Debian/ group. I have already added you as a maintainer
> of https://salsa.debian.org/debian/cpufrequtils .

I really appreciate it. After your confirmation and sponsor, I will
move all contents to the repository. The debian/control was already
changed to the repo.

> As part of mentoring, I reviewed your files in the git repo and found some
> other issues:
> * You accidentally committed files under debian/cpufrequtils into the
> repository. Those files are built binary files instead of source codes and
> should not be included.
>   - This also indicates that you are using a non-chroot environment to build
> packages. Please consider using clean chroot each time doing a package build,
> like pbuilder, cowbuilder, git-builder, sbuild, etc.

Sorry for my mistake. It was my fault, and I didn't intend to add the
binary files. I will use the pbuilder for avoiding this kind of

> * In architecture field of package cpufrequtils, it lists "hurd", "kbsd64" and
> "kbsd32", which does not exist in Debian. Please correct it. (I know it could
> be a bug in older versions but we should be fixing it once we know it.)
> * You may now use https://salsa.debian.org/debian/cpufrequtils in Vcs-*
> fields.

I fixed these issues with your advice.

> * I'm not sure if debian/lintian.overrides will work.
> https://manpages.debian.org/unstable/lintian/lintian.1.en.html#FILES mentioned
> correct naming about lintian override files.
> After solving those problems, I will sponsor this package.

According to my lintian report, debian/lintian.overrides seemed to
work. The brief report is below.
$> lintian -i -I --pedantic cpufrequtils_008-2_amd64.changes
[... snip ...]
N: 1 tag overridden (1 error)     <= Maybe this point shows it works

> Some bonus points that can be done laster in future:
> * Consider converting debian/rules to be using dh(1) sequencer later.

Thank you. I will keep this for the next item.

Best regards,


Reply to: