Hi Seunghun, 在 2020-05-05星期二的 10:02 +0900，Seunghun Han写道： > Hi Boyuan, > > Thank you for your advice. Please see comments below. > > On Tue, May 5, 2020 at 6:33 AM Boyuan Yang <byang@debian.org> wrote: > > [..snip..] > > Are you interested putting the git packaging repo under > > salsa.debian.org/debian/ instead of your personal namespace? In this case, > > other Debian Developers (DD) will have write access to this repo. If you > > find > > it okay, I can help to create such repo under Salsa Debian group. > > > > Thank you for your suggestion. It's good for me. Is there any way to > have write access for it? In my case, I joined the Webml team as a > developer and had write access [1]. The members of salsa.debian.org/debian group are limited to DDs (Debian Developers). However, it is possible to add you as the maintainer of individual repos under Debian/ group. I have already added you as a maintainer of https://salsa.debian.org/debian/cpufrequtils . > hose are all just nitpicks; I can sponsor this upload after your reply (and > > > > > > I also fixed them and uploaded the package again. Please sponsor it. > I always appreciate your help. As part of mentoring, I reviewed your files in the git repo and found some other issues: * You accidentally committed files under debian/cpufrequtils into the repository. Those files are built binary files instead of source codes and should not be included. - This also indicates that you are using a non-chroot environment to build packages. Please consider using clean chroot each time doing a package build, like pbuilder, cowbuilder, git-builder, sbuild, etc. * In architecture field of package cpufrequtils, it lists "hurd", "kbsd64" and "kbsd32", which does not exist in Debian. Please correct it. (I know it could be a bug in older versions but we should be fixing it once we know it.) * You may now use https://salsa.debian.org/debian/cpufrequtils in Vcs-* fields. * I'm not sure if debian/lintian.overrides will work. https://manpages.debian.org/unstable/lintian/lintian.1.en.html#FILES mentioned correct naming about lintian override files. After solving those problems, I will sponsor this package. Some bonus points that can be done laster in future: * Consider converting debian/rules to be using dh(1) sequencer later. -- Regards, Boyuan Yang
Attachment:
signature.asc
Description: This is a digitally signed message part