On Tue, Apr 14, 2020 at 03:37:03PM +0200, Stephen Sinclair wrote:
> On Fri, Apr 10, 2020 at 4:56 PM Mattia Rizzolo <mattia@debian.org> wrote:
> >
> > On Fri, Apr 10, 2020 at 04:51:01PM +0200, Stephen Sinclair wrote:
> > That's because you didn't close the bug in the upload.
> > * debian/rules: Remove use of ccache. (Closes: #945613 #954497)
> > > Is this not the correct syntax for fixing multiple bugs?
> > you'd need a comma to list more than bug after the 'Closes:', so it
> > wasn't closed.
>
> Thank you, I am confused because I actually checked the policy manual
> carefully before doing this, and it clearly states that multiple bugs
> should be space-separated. Is it an error in the document?
>
> https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-closes
That's about the .changes file. For the changelog file see §4.4:
|If this upload resolves bugs recorded in the Bug Tracking System (BTS),
|they may be automatically closed on the inclusion of this package into
|the Debian archive by including the string: closes: Bug#nnnnn in the
|change details. [5] This information is conveyed via the Closes field
|in the .changes file (see Closes).
if you then go look at what is the currently number 5 footnote:
|To be precise, the string should match the following Perl regular
|expression:
|/closes:\s*(?:bug)?\#?\s?\d+(?:,\s*(?:bug)?\#?\s?\d+)*/i
there you can see the comma.
that footnote mentions dak, but this is actually parsed by
dpkg-genchanges. More specifically, the perl module
Dpkg::Changelog::Entry::Debian::find_closes(), there you can see:
453 while ($changes && ($changes =~ m{
454 closes:\s*
455 (?:bug)?\#?\s?\d+
456 (?:,\s*(?:bug)?\#?\s?\d+)*
457 }pigx)) {
458 $closes{$_} = 1 foreach (${^MATCH} =~ /\#?\s?(\d+)/g);
459 }
then the list of bugs is copied into the Closes: field of the .changes
in the format that you mentioned, space separated.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature