[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]



On 15 February 2018 at 15:33, Félix Sipma <felix+debian@gueux.org> wrote:

> I don't get the harm in having a little more verbose initial changelog, we're
> talking about 10 lines there, not a whole book... Anyway, I've just kept the
> attribution and a line mentioning the lack of python3 support.
>

>> OK. You can override it and leave a note in lintian-overrides file.
>
> I'd really prefer keeping the warning reported, so that adding the manpage in not
> forgotten later :-).

OK.

>>>> I: youtube-dl-gui: dependency-on-python-version-marked-for-end-of-life
>>>> (Depends: python)
>>
>> I noticed that python3-wxgtk4.0 is in the NEW queue [1].
>> Do we have a chance to build on python3-wxgtk4.0 and
>> get rid of python2?
>>
>> [1] https://ftp-master.debian.org/new/wxpython4.0_4.0.1+dfsg-1.html
>
> Sorry, I don't have the resources to do the wxgtk3.0->4.0 migration myself, but
> I'll see with upstream what can be done, I'll be happy to drop python2, too

One more problem:

146 diff --git a/youtube_dl_gui/optionsmanager.py
b/youtube_dl_gui/optionsmanager.py
147 index 794f590..baa6b83 100644
148 --- a/youtube_dl_gui/optionsmanager.py
149 +++ b/youtube_dl_gui/optionsmanager.py
150 @@ -276,7 +276,7 @@ class OptionsManager(object):
151              'username': '',
152              'password': '',
153              'video_password': '',
154 -            'youtubedl_path': self.config_path,
155 +            'youtubedl_path': '/usr/bin/',
156              'cmd_args': '',
157              'enable_log': True,
158              'log_time': True,

This part seems unrelated to auto update functionality. Would you
mind splitting it to another patch?

Please provide an uploaded version of this package via mentors
so I can check it on debomatic :-)
(if you don't have access to debomatic)


-- 
Best,


Reply to: