Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]
control: owner -1 !
control: tag -1 +moreinfo
Hi Félix,
Some comments on your package:
changelog
---------------
* One line is enough for the initial upload, e.g.
"Initial release. (Closes: #753350)"
compat & control
-------------------------
* I'd recommend to use debhelper compat level 11
since 10 is old.
* This package looks like a front-end of youtube-dl,
why is "youtube-dl" in Recommends section
instead of Depends section?
* Python2 faces its end of life. Does upstream support
python3? see [1]
rules
-------
You may need to add this to override_dh_auto_test target
if you bump debhelper compat to 11:
override_dh_auto_test:
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
YOUR TEST STUFF
endif
lintian
--------
Would you mind to fix the following: (lintian -EviI --pedantic)
W: youtube-dl-gui: binary-without-manpage usr/bin/youtube-dl-gui
I: youtube-dl-gui: dependency-on-python-version-marked-for-end-of-life
(Depends: python)
P: youtube-dl-gui: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/youtube_dl_gui/data/pixmaps/arrow_down_32px.png
[1] https://www.debian.org/doc/packaging-manuals/python-policy/python3.html
--
Best,
Reply to: