[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]



Control: tag -1 -moreinfo

Hi,

Thanks for your review.

Changelog: is there a problem with being more verbose? I like writing about
specificities of a package and it's one of the places (with debian/rules) where
I did write a comment concerning python3 support (needs python3-wxgtk3.0).

> compat & control
> -------------------------
> 
> * I'd recommend to use debhelper compat level 11
>  since 10 is old.

Done.


> * This package looks like a front-end of youtube-dl,
>   why is "youtube-dl" in Recommends section
>   instead of Depends section?

Done.

> Would you mind to fix the following: (lintian -EviI --pedantic)
> 
> W: youtube-dl-gui: binary-without-manpage usr/bin/youtube-dl-gui

I already asked upstream to provide a manpage.
https://github.com/MrS0m30n3/youtube-dl-gui/issues/259
I'll push the manpage with the next release.

> I: youtube-dl-gui: dependency-on-python-version-marked-for-end-of-life
> (Depends: python)

See debian/rules & debian/changelog

> P: youtube-dl-gui: image-file-in-usr-lib
> usr/lib/python2.7/dist-packages/youtube_dl_gui/data/pixmaps/arrow_down_32px.png

It's a "P", so I guess it's not so important...

Attachment: signature.asc
Description: PGP signature


Reply to: