[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890379: RFS: python-jsonrpc/1.10.8-1 [ITP]



2018-02-15 8:33 GMT+00:00 Lumin <cdluminate@gmail.com>:
> control: merge -1 880442
> control: owner -1 !
> control: tag -1 +moreinfo
>
> Hi Ghislain,
>
> Some comments on this package:
>
> 1. please fix the following copyright issue:
>    (reproduce with $ licensecheck -r .)
>
> ./jsonrpc/six.py: MIT/X11 (BSD like)
>    Copyright (c) 2010-2013 Benjamin Peterson
>
> There is six.py. What's the relationship between it and python3-six?
> My preliminary guess is that upstream just copied that file to their
> project.

Correct. Don't think it is worth repacking though.

I will update d/copyright accordingly.

> 2. This package failed to build when python2 version of sphinx exists:
>
> make[2]: Entering directory
> '/home/lumin/packages/sponsor/python-jsonrpc-1.10.8/docs'
> sphinx-build -b html -d _build/doctrees   source _build/html
> Running Sphinx v1.6.7
> making output directory...
>
> Configuration error:
> There is a programable error in your configuration file:
>
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/dist-packages/sphinx/config.py", line 157,
> in __init__
>     execfile_(filename, config)
>   File "/usr/lib/python2.7/dist-packages/sphinx/util/pycompat.py",
> line 150, in execfile_
>     exec_(code, _globals)
>   File "/usr/lib/python2.7/dist-packages/six.py", line 709, in exec_
>     exec("""exec _code_ in _globs_, _locs_""")
>   File "<string>", line 1, in <module>
>   File "conf.py", line 109, in <module>
>     import sphinx_rtd_theme
> ImportError: No module named sphinx_rtd_theme
>
> make[2]: *** [Makefile:45: html] Error 1
> make[2]: Leaving directory
> '/home/lumin/packages/sponsor/python-jsonrpc-1.10.8/docs'
> make[1]: *** [debian/rules:21: override_dh_auto_build] Error 2
> make[1]: Leaving directory '/home/lumin/packages/sponsor/python-jsonrpc-1.10.8'
> make: *** [debian/rules:9: build] Error 2
> dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
> debuild: fatal error at line 1152:
> dpkg-buildpackage -rfakeroot -us -uc -ui -i failed

I don't care to be honest.

It builds fine on a clean chroot with the Python 3 version of Sphinx:

http://debomatic-amd64.debian.net/distribution#unstable/python-jsonrpc/1.10.8-1/buildlog

That's all that matters.

Ghis


Reply to: