In general, the package is in a releasable state already. Network play
doesn't work, but the game itself is playable.
Please tell me if you'd want to upload to NEW now (and improve in a
subsequent version) or get it fully working from the in-archive start.
On Sat, Dec 30, 2017 at 12:46:40AM +0300, Ivan wrote:
29.12.2017 01:51, Adam Borowski пишет:
debian/changelog:
* you need to file an ITP bug ("reportbug wnpp") and put its number here.
ITPs are there so people are notified about what you're going to package.
In this case, it's pretty unlikely anyone will object, and we already did
the review, but it's a formality that costs us little.
Bug #884780 is this RFS.
* as the package is meant for upload, please s/UNRELEASED/unstable/
Change UNRELEASED to unstable but:
Now running lintian...
E: piu-piu changes: bad-distribution-in-changes-file unstable
Finished running lintian.
From the version of your nc I see you're running an old version of Ubuntu,
it has lintian that's 1. outdated, 2. configured for Ubuntu. Thus, it's
output will be obviously wrong.
I also couldn't get network play to work: it just hangs on both client and
server. But single player mode appears to be fine.
Network, hm... Maybe nc version is different?
I had netcat-traditional installed, but netcat-openbsd doesn't work either.
I checked with this wersion:
ii netcat-openbsd 1.105-7ubuntu1 amd64 TCP/IP swiss army knife
Works fine.
And here we go. 1.105-7ubuntu1 means either trusty or xenial. I installed
xenial, indeed it works -- but only xenial<->xenial. When either the server
or the client uses a newer release, it doesn't connect.
However, not only xenial is an old release (there were yakkety, zesty and
artful in meantime), but also the first version of Ubuntu that can possibly
ship your game is bionic. It has netcat-openbsd 1.187-1, same as Debian
unstable, thus I assume it won't work.
Obviously, what I care about is Debian not Ubuntu, but they're on the same
boat.
Also, if the game needs netcat for some functionality, it should declare
at least Suggests: or Recommends: netcat. Or perhaps even Depends:, as
while network play will probably be used only by a minority of users, both
netcat implementations are tiny packages that do no harm by being installed.
Also, compared to the previous submission, I see in the diff:
-Build-Depends: debhelper (>= 10)
-Standards-Version: 4.1.1
+Build-Depends: debhelper (>= 9)
+Standards-Version: 3.9.7
While using an old compat version is ok (useful for backports to old
releases), it's better to declare up to date standards.
It's not a show-stopper issue, though. If you wish to ignore it, I can
upload as-is.
Meow!