[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832941: RFS: 4pane



Dear David,

On Tue, Mar 28, 2017 at 01:36:03PM +0100, David Hart wrote:
> Hmm, I can't make it fail here. e.g.

Sorry, I assumed that uscan would redownload the .pgp file, but it was
using the old one.  Apologies for wasting your time with that.

While you previously said that everything remaining in .build/ is your
own work, the file wxwin.m4 is not yours.  So that needs to be added to
d/copyright.

The patch header for ChangeToAutomakeBuild.patch does not make sense...

These two are the only remaining issues in d35ef45.

As a suggestion, strictly optional:

I also noticed that you often cram several copyright lines into a single
line.  Please consider using line breaks.  E.g.

Copyright: 2005-2014, Mike Hommey <glandium@debian.org>
 1998-2010, Mozilla Project

instead of

    Copyright: 2005-2014, Mike Hommey <glandium@debian.org> 1998-2010, Mozilla Project

Similarly for some Files: fields.

If you're able to address the issues I've raised in this message, please
remove the moreinfo tag in this bug, and don't forget to re-run `dch -r`
to refresh the changelog timestamp.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: