Bug#832941: RFS: 4pane
Dear Sean,
>Sorry, I assumed that uscan would redownload the .pgp file, but it was
>using the old one. Apologies for wasting your time with that.
That's OK, I've wasted plenty of yours ;)
>While you previously said that everything remaining in .build/ is your
>own work, the file wxwin.m4 is not yours. So that needs to be added to
>d/copyright.
Ah, I see the problem. In the tarball .build/ contains only 3 files, all mine.
However a 4th is added by ChangeToAutomakeBuild.patch, and that does indeed
need a d/copyright entry. I've added one, calling it .build/wxwin.m4 as that's
where it will end up. Please let me know if I should instead have referred to
d/patches/.
>The patch header for ChangeToAutomakeBuild.patch does not make sense...
Well spotted. A copy/paste error, now fixed.
>These two are the only remaining issues in d35ef45.
>I also noticed that you often cram several copyright lines into a single
>line. Please consider using line breaks.
Done.
>If you're able to address the issues I've raised in this message, please
>remove the moreinfo tag in this bug, and don't forget to re-run `dch -r`
>to refresh the changelog timestamp.
I hope I've removed the tag, though the bug's status has not yet updated.
Regards,
David Hart
Reply to: