On Sat, Mar 19, 2016 at 10:11:07PM +0000, Christopher Baines wrote:
> I think I realised when I read this, that the source and binary package
> names can be handled separately, so I have gone ahead and renamed the
> source package to faker [1]. I'll delete the other (fake-factory)
> repository and try to update the BTS tomorrow, if I hear no objections.
yeah, looks cool. please delete the other.
> The issues that you commented on above are fixed in this repository.
>
> 1: https://anonscm.debian.org/cgit/python-modules/packages/faker.git
of what I wrote before these still need fixing:
* debian/control:
+ I: fake-factory source: duplicate-long-description python-fake-factory python3-fake-factory
+ I: python-fake-factory: extended-description-is-probably-too-short
+ I: python3-fake-factory: extended-description-is-probably-too-short
of the manpage erros you output, I can see man has to complain about
this:
<standard input>:8: warning [p 1, 1.7i]: cannot adjust line
<standard input>:8: warning [p 1, 1.8i]: can't break line
<standard input>:33: warning [p 1, 5.3i, div `an-div', 0.0i]: cannot adjust line
<standard input>:33: warning [p 1, 5.3i, div `an-div', 0.2i]: can't break line
<standard input>:33: warning [p 1, 5.3i, div `an-div', 0.3i]: cannot adjust line
<standard input>:33: warning [p 1, 5.3i, div `an-div', 0.5i]: can't break line
Indeed `faker --help` outputs this
-l {lt_LT,lv_LV,de_AT,tr_TR,sv_SE,no_NO,pt_PT,it_IT,en_US,en_CA,en,zh_TW,fi_FI,hi_IN,hr_HR,fa_IR,bg_BG,zh_CN,sk_SK,fr_FR,en_GB,dk_DK,es,en_AU,sl_SI,el_GR,la,de_DE,bs_BA,uk_UA,pt_BR,nl_NL,pl_PL,ru_RU,cs_CZ,ja_JP,es_ES,ko_KR,es_MX,ne_NP}, --lang {lt_LT,lv_LV,de_AT,tr_TR,sv_SE,no_NO,pt_PT,it_IT,en_US,en_CA,en,zh_TW,fi_FI,hi_IN,hr_HR,fa_IR,bg_BG,zh_CN,sk_SK,fr_FR,en_GB,dk_DK,es,en_AU,sl_SI,el_GR,la,de_DE,bs_BA,uk_UA,pt_BR,nl_NL,pl_PL,ru_RU,cs_CZ,ja_JP,es_ES,ko_KR,es_MX,ne_NP}
specify the language for a localized provider (e.g.
de_DE)
well, that's awful.
did you manually fix this in the build manpage by any chance?
imho the proper fix for this thing would be to have argparse (or
whatever thing this library/app is using to parse the options) to not
output the recognized options, and output them formatted in a saner way
(e.g. separated by ', ') at the bottom of the --help, then maybe
help2man will need some help to handle that correctly, though.
And BTW, I have another feeling that the list of languages is stored
inside a set, and that is passed to argparse as a list of valid options;
well, that makes argparse output non-reproducible, and as such the
generated manpage is non reproducible; please make that either a real
list (so the elements have a fixed position) or sort the set before
passing it over to argparse, so that the output is reproducible between
runs (and as such between rebuilds).
https://paste.debian.net/plain/417202 (this is not built with the
reproducible toolchain, and as such there is noise about filesystem
order (actually there is not, but this is by chance) and timestamps
inside the {control,data}.tar member of the .deb, that in the
reproducible toolchain is fixed by a patched dpkg not yet included in
dpkg mainstream)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature