control: tag -1 moreinfo
control: owner -1 !
On Sun, Feb 28, 2016 at 09:48:30AM +0000, Christopher Baines wrote:
> I am looking for a sponsor for "fake-factory"
ok.
> dget -x
> http://mentors.debian.net/debian/pool/main/f/fake-factory/fake-factory_0.5.3-1.dsc
>
> It is also available on git.debian.org:
>
> https://anonscm.debian.org/cgit/python-modules/packages/fake-factory.git/
being in DPMT and given that by team policy the git repo should reflect
what's packaged, I'm going to ignore what's on mentors.d.n.
* debian/changelog:
+ bump the date, Dec 2015 is really too old
* debian/control:
+ bump Standards-Version
+ u.U this is in DPMT, git is *mandatory*, how could you miss Vcs-Git
and Vcs-Browser here?
+ I: fake-factory source: duplicate-long-description python-fake-factory python3-fake-factory
+ I: python-fake-factory: extended-description-is-probably-too-short
+ I: python3-fake-factory: extended-description-is-probably-too-short
* debian/copyright:
+ the 'License: Expat' paragraph contains a copyright statment, please
remove it, after this is a *license* paragraph, not copyright.
+ I can clearly see that you did work in 2016, so please also claim
copyright over 2016 too.
* debian/gbp.conf:
+ how so there is this file? DPMT mandates git-dpm, and the content
of this file is worrisome
* debian/.git-dpm:
+ you haven't initialized it to follow the DPMT rules, so the tag you
created are in the wrong format. See
https://wiki.debian.org/Python/GitPackaging#Tag_style then delete
those tags.
- more: there is tag "patched-0.5.3-1", but that one is done once
the package is ready, togheter with the debian/* one, so don't
create/push that tag after you'll remove it.
Now, something maybe more difficult:
as lintian notices:
X: python-fake-factory: library-package-name-for-application usr/bin/faker2
X: python-fake-factory: application-in-library-section python usr/bin/faker2
X: python3-fake-factory: library-package-name-for-application usr/bin/faker3
X: python3-fake-factory: application-in-library-section python usr/bin/faker3
you are installing something in PATH. ok.
I see this was done by upstream, but providing /usr/bin/faker{2,3} where
the only difference is the python version used is very confusing.
Nowdays the better way to fix that is to ship only one binary, using the
python3 library, in a separate package (maybe named "faker")
Another thing: please build the manpage at build time, by calling
help2man directly there.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature