On Sat, Mar 19, 2016 at 05:34:20PM +0000, Christopher Baines wrote:
> On 19/03/16 14:11, Mattia Rizzolo wrote:
> I began packaging this before my application to join the team was
> approved, and when this happened and I pushed the package to the
> repository, I forgot to add the related metadata in to the control file.
I see :)
though, Vcs-Git is wrong:
+Vcs-Git:
https://anonscm.debian.org/python-modules/packages/fake-factory.git
that's 404, you need a /git/ in the middle.
> > Another thing: please build the manpage at build time, by calling
> > help2man directly there.
>
> Thanks for your review. I have now fixed most of the issues you have
> highlighted. The manpage still needs a bit of work, the help output
> contains some long lines, and I think this is causing a lintian warning
> (but I'm not sure how to fix this?).
another thing is that you need to remove the built manpage in the clean
target (e.g. add it to debian/clean)
and please entirely remove debian/gbp.conf, no point in keeping it as a
0-byte file ;)
> The other issue that has arisen since making this sponsorship request,
> is that the upstream maintainers have announced that the project is
> changing name in September (fake-factory -> faker). This is good, but it
> means that the Debian source package and binary packages should also
> make this change. I am not sure of the process around changing source
> package name, but I guess the two options would be to upload, change
> name upload in September, or just wait until September before uploading
> this package?
well, yes, those are the two options.
Another option is to already change the name now in Debian only.
I wonder why upstream is taking a so long timeframe to renme the
project...
Personally I wouldn't find much of a problem in re-uploading this in
Septmber, it needs to go through NEW again, and you'll have to ask for
removal of the old one, but it's feasible.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature