[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#811447: RFS: gtk3-nocsd/2-1 [ITP] -- Disable Gtk+ 3 client side decorations (CSD)



On 03/19/2016 02:34 PM, Mattia Rizzolo wrote:
> * please configure the remote git repository to have HEAD pointing to
>   the packaging branch, which is != master

I knew I forgot something. *git symbolic-ref*

Done.

> * given that this is != master please specify the branch name in Vcs-Git
>   (this is optional if you fix the above, but imho it's better to do
>   both)

Done.

> * please use https and cgit in Vcs-Browser, the very same url that you
>   are using in Vcs-Git is valid in Vcs-Browser too nowadays, so just
>   copy the line over

While it was https before, now it's also cgit instead of gitweb.

>> Since this is a LD_PRELOAD-able library, I seriously doubt anybody
>> will try to create a derivative work of the resulting binary (which
>> could arguably be under GPL-2+). OTOH, I don't particularly care, so
>> I've changed it to LGPL-2.1+ also for debian/*.
> 
> it's not just about possible derivatives work, but also about patches,
> if you write a patch in debian/patches with such debian/copyright it
> should be considered under GPL-2+, and upstream wouldn't be able to
> import it.  That's the theory, at least.

Oh, I didn't think of that. Yeah, that's a very good point. I just
made a mental note of that for future packaging efforts.

> Now, given that you have set up a git repository, feel free to just
> forget mentors, and just push to git, I'll then just pull ^^

So I pushed the Vcs-* field changes to collab-maint now (and you
can now clone it properly :)), and fixed the repository on alioth
to have a correct HEAD. I didn't regenerate debian/changelog again,
because that would just change the date a tiny bit.

I think that covers all of your remarks, if I didn't miss anything.

Regards,
Christian

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: