Control: tag -1 - moreinfo On 03/19/2016 12:34 PM, Mattia Rizzolo wrote: > On Tue, Jan 19, 2016 at 02:01:19AM +0100, Christian Seiler wrote: >> I am looking for a sponsor for my package "gtk3-nocsd" > > alright. Many thanks! >> dget -x http://mentors.debian.net/debian/pool/main/g/gtk3-nocsd/gtk3-nocsd_2-1.dsc > > a review: > > * d/control: > + there are commented out Vcs-Git and Vcs-Browser, either set up a > repository or remove the lines altogether I've now set up a repository on collab-maint for that and added the headers. > + please bump standards-version Done. > + please use wrap-and-sort (or cme) to wrap and sort the build-deps Done. > * d/copyright: > + the changelog and this RFS have been done in 2016, maybe also the > copyright of debian/* can be claim for 2016? Done. > + why did you chose a different license for debian/* than the one of > the rest of the package? This can actually pose a problem, since > GPL-2+ is more restrictive than LGPL-2.1+. I used the default license of dh-make for the Debian packaging part. Since this is a LD_PRELOAD-able library, I seriously doubt anybody will try to create a derivative work of the resulting binary (which could arguably be under GPL-2+). OTOH, I don't particularly care, so I've changed it to LGPL-2.1+ also for debian/*. > * please rename d/docs to d/gtk3-nocsd.docs to be more clear (if you > don't specify the package name it'll act only on the first package > listed in d/control) Done. I removed the package from mentors and re-uploaded it there: http://mentors.debian.net/package/gtk3-nocsd http://mentors.debian.net/debian/pool/main/g/gtk3-nocsd/gtk3-nocsd_2-1.dsc Regards, Christian
Attachment:
signature.asc
Description: OpenPGP digital signature