[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#821270: Review of firefox-branding-iceweasel



Hello,

I just took a closer look at your debian/rules file.  You don't need the
boilerplate.  This is enough:

,----
| #!/usr/bin/make -f
| 
| %:
| 	dh $@ --with xul-ext --parallel
| 
| override_dh_auto_install:
| 	xpi-pack ./xpi-build ./build.xpi
| 	install-xpi ./build.xpi
`----

However, since this is a native package, would you consider editing your
Makefile so that dh_xul-ext can do your whole build for you?  Take a
look at the source package y-u-no-validate.  It uses this main Makefile
target:

,----
| %:
| 	dh $@ --with xul-ext --buildsystem=xul_ext --sourcedirectory=src
`----

There is an override, but it's just something minor.  This works because
the source code is organised in a standard way, but your code seems to
be organised in a non-standard way which is why you need a complex
Makefile and dh overrides.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: