[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#821260: RFS: python-adventure/1.4-1 [ITP], Bug#821260: RFS: python-adventure/1.4-1 [ITP]



Howdy Markus,

(Limiting distribution just to the RFS bug report to discuss the
sponsorship.)

Markus Koschany <apo@debian.org> writes:

> Am 18.04.2016 um 02:15 schrieb Ben Finney:
> > Those are in end-line comments (“# foo”). My understanding is that
> > end-line comments with that syntax are permitted in any Debian
> > control files.
>
> cme check dpkg made me aware of this and it probably refers to:
> https://www.debian.org/doc/debian-policy/ch-controlfields#s-controlsyntax

That's right, thank you for showing it to me.

I don't think that restriction is justified, and have now filed
bug#821363 to effect a change in that policy.

Until then, the specification has the meaning as you described it. I
have removed those comment lines from ‘debian/copyright’.

> CC-BY-4.0 is a good choice and would help to avoid any confusion.

Done.

> I can live with the python3-adventure split off but as Bas already
> said I also find it unlikely that another program will ever make use
> of it.

Another reason was that Pybuild and dh_python make it much easier to
handle the package build when there is a ‘python3-libraryname’ package
containing the library.

However, you have convinced me that it is misleading to present a
‘python3-adventure’ when the package does not install a public module to
be imported.

I have merged the Python library back into the main application binary
package.

> Could you remove those ^L form feed characters please?

Done.


> desktop-file-validate is a useful tool to ensure compliance with the
> freedesktop specification. The written text can be found at
>
> https://specifications.freedesktop.org/menu-spec/latest/

Thank you. I have corrected the badly-formatted field in the desktop
entry.

> Another suggestion: The recommended location for hicolor icons is
> /usr/share/icons/hicolor.

These are deliberately low-colour icons (8 colours and 16 colours) to
reduce the file size; but there doesn't appear to be an XDG standard
place for low-colour icons.

> If you resize your icons to 256x256 you could install them to
> /usr/share/icons/hicolor/256x256/apps and replace the absolute icon
> path in your desktop file with the icon name.

Done.


The resulting updated source package is available:

    $ dget -x http://mentors.debian.net/debian/pool/main/p/python-adventure/python-adventure_1.4-1.dsc

-- 
 \      “Every valuable human being must be a radical and a rebel, for |
  `\      what he must aim at is to make things better than they are.” |
_o__)                                                      —Niels Bohr |
Ben Finney <ben@benfinney.id.au>


Reply to: