[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#821270: Review of firefox-branding-iceweasel



The package is mostly fine.  Here are some points:

- binary package name should be xul-ext-iceweasel-branding or similar

- is it possible to generalise this to restore both icedove and
  iceweasel branding in one binary package?  (icedove will soon become
  thunderbird)

- don't install the MPL-* files using debian/docs.  Instead, include the
  full license text in debian/copyright.

- as Gianfranco suggested, this should be team maintained.  Your name
  should be in the Uploaders: field in debian/control, and Maintainer:
  should be the Mozilla extensions packaging team.  You should upload
  the git repository to the Mozilla extensions team section of alioth.
  Do you have an alioth account?

- the long description is not, IMO, appropriate.  You should include the
  history of the package in the README.markdown, and just give a terse
  description of what it does in the long description (or at least in
  the first paragraph of the long description)

- on my machine, the package doesn't change the application icon -- see
  the top of the attached screenshot.  Maybe you can't fix that, though.

-- 
Sean Whitton

Attachment: noicon.png
Description: PNG image

Attachment: signature.asc
Description: PGP signature


Reply to: