[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#811264: RFS: rhythmbox-plugin-alternative-toolbar/0.16.3-1

thanks for getting back so fast.

1. changelog.  This has been revised with better explanation.  I've changed back the first entry as requested and changed the Maintainer field in control.  I've added an explanation as to why we need python3-gi
2. I've updated the version field for some of the more important build-dependencies.  The package is targeting Jessie as a minimum - although obviously Stretch is the next stable.  I've adjusted some of the build versions to accommodate debian derivatives such as Ubuntu Trusty (14.04) where I've been testing also via a PPA
3. Copyright version - updates as requested to include 2016
4. postrm vs postinst ... must have had a brain freeze.  Changed to postinst with an explanation in the change log.  

If you suggest dumping prerm and postinst then quite content to do-so.  Note - I havent found a way to get debhelper to automatically byte-compile the python modules.  All the examples suggest I should use distutils in the dh_autoinstall which seems strange and complex to have both an autogen/configure/make/make-install and a distutils-setup.py as well doing much the same thing.  Having a prerm/postinst to my mind much simpler to understand/maintain etc.

Anyway - have uploaded to mentors and the mentors web-page now says the linitian is clean.

 - http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.16.3-1.dsc



On 18 January 2016 at 10:17, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:
control: owner -1 !
control: tags -1 moreinfo

let's review:


1) changelog:

- -- fossfreedom <foss.freedom@gmail.com>  Mon, 28 Dec 2015 19:20:43 +0000
+ -- David Mohammed <foss.freedom@gmail.com>  Mon, 28 Dec 2015 19:20:43 +0000

you changed the first changelog entry, not a big problem, but you might want to change it

- lintian is complaining about NMU, probably because you have to update also the maintainer field

- the changelog needs a little update.

fixes that are part of upstream new release should be carried inside that entry.
 * New upstream release. (Closes: #811263)

    - include upstream changelog
    - drag and drop of column headers (issue 67)
    - slider greyed out on start (issue 69)
    - Translations displayed correctly (issue 64)

--> * Packaging changes (byte-compilation, dependencies)

this is so generic.

you might change with "add python3-gi build dependency, needed for foo
add some version constraints, needed for foo/bar
2) control:
-               dh-python,
+               dh-python (>= 1.20130903),

this change makes me think you didn't start from the unstable version on your packaging changes.
the version of dependencies are already satisfied in old-old-stable, so you can just remove them.

the add of python3-gi has a rationale?
(I'm fine with new dependencies, as long as they are needded and not a leftover of a bad packaging change)

3) copyright:
-Copyright: 2015 fossfreedom <foss.freedom@gmail.com>
+Copyright: 2015 David Mohammed <foss.freedom@gmail.com>

maybe you might want to change in
Copyright: 2015-2016 David Mohammed <foss.freedom@gmail.com>


about the postrm/prerm scripts, I'm not sure they are worth the effort.

"python3 -m compileall /usr/lib/rhythmbox/plugins/alternative-toolbar/ > /dev/null 2>&1"

you compile the python stuff in the postrm script?
so when a user removes the package the files are compiled?
maybe it was postinstall? :)

in fact adeguate still complains


let me know when you have addressed the above.



Reply to: