[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#811264: marked as done (RFS: rhythmbox-plugin-alternative-toolbar/0.16.3-1)

Your message dated Thu, 21 Jan 2016 10:29:35 +0000 (UTC)
with message-id <307454993.13702662.1453372175091.JavaMail.yahoo@mail.yahoo.com>
and subject line Re: Bug#811264: RFS: rhythmbox-plugin-alternative-toolbar/0.16.3-1
has caused the Debian Bug report #811264,
regarding RFS: rhythmbox-plugin-alternative-toolbar/0.16.3-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

811264: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811264
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: wishlist

Dear Mentors,

I am looking for a sponsor for my package

* Package name    : rhythmbox-plugin-alternative-toolbar
  Version         : 0.16.3-1
  Upstream Author : David Mohammed <foss.freedom@gmail.com>
* URL             : https://github.com/fossfreedom/alternative-toolbar
* License         : GPL3+
  Section         : gnome

It builds those binary packages:

    rhythmbox-plugin-alternative-toolbar - Enhanced play controls and interface for Rhythmbox

  To access further information about this package, please visit the
following URL:


  Alternatively, one can download the package with dget using this command:

    dget -x http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.16.3-1.dsc

  More information about rhythmbox-plugin-alternative-toolbar can be
obtained from https://github.com/fossfreedom/alternative-toolbar.
  Additionally I have a blog post about this work here:


Notes - this is an update to my previous version v0.15.0 that is in unstable

- https://packages.debian.org/sid/rhythmbox-plugin-alternative-toolbar

Changes since the last upload: * New upstream release. (Closes: #811263) * Packaging changes (byte-compilation, dependencies) * Include ChangeLog * Drag-drop of column headers (issue 67) * slider greyed out on start (issue 69) * Translations displayed correctly (issue 64)
Tests Run:
grep -riE 'fixme|todo|hack|xxx' . suspicious-source pyflakes . pyflakes3 . pep8 --ignore W191 . find -type f \( -iname '*.po' -o -iname '*.pot' \) -exec msgfmt --check --check-compatibility --check-accelerators --output-file=/dev/null {} \; from the built and installed package: adequate rhythbox-plugin-alternative-toolbar

Finally - I've been asked to use my full name "David Mohammed" in the changelog - hence I've done so. Is that the reason why I get two linitian errors "NMU" since my last upload was with "fossfreedom" ? How should I deal with this?

Regards, David Mohammed (fossfreedom)

--- End Message ---
--- Begin Message ---
Hi, I'll sponsor in a few moments, just some testing and I think we are fine.

and thanks for your contribution to Debian!

Il Lunedì 18 Gennaio 2016 22:12, foss.freedom <foss.freedom@gmail.com> ha scritto:

thanks for getting back so fast.

1. changelog.  This has been revised with better explanation.  I've changed back the first entry as requested and changed the Maintainer field in control.  I've added an explanation as to why we need python3-gi
2. I've updated the version field for some of the more important build-dependencies.  The package is targeting Jessie as a minimum - although obviously Stretch is the next stable.  I've adjusted some of the build versions to accommodate debian derivatives such as Ubuntu Trusty (14.04) where I've been testing also via a PPA
3. Copyright version - updates as requested to include 2016
4. postrm vs postinst ... must have had a brain freeze.  Changed to postinst with an explanation in the change log.  

If you suggest dumping prerm and postinst then quite content to do-so.  Note - I havent found a way to get debhelper to automatically byte-compile the python modules.  All the examples suggest I should use distutils in the dh_autoinstall which seems strange and complex to have both an autogen/configure/make/make-install and a distutils-setup.py as well doing much the same thing.  Having a prerm/postinst to my mind much simpler to understand/maintain etc.

Anyway - have uploaded to mentors and the mentors web-page now says the linitian is clean.

 - http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.16.3-1.dsc



On 18 January 2016 at 10:17, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:

control: owner -1 !
>control: tags -1 moreinfo
>let's review:
>1) changelog:
>- -- fossfreedom <foss.freedom@gmail.com>  Mon, 28 Dec 2015 19:20:43 +0000
>+ -- David Mohammed <foss.freedom@gmail.com>  Mon, 28 Dec 2015 19:20:43 +0000
>you changed the first changelog entry, not a big problem, but you might want to change it
>- lintian is complaining about NMU, probably because you have to update also the maintainer field
>- the changelog needs a little update.
>fixes that are part of upstream new release should be carried inside that entry.
> * New upstream release. (Closes: #811263)
>    - include upstream changelog
>    - drag and drop of column headers (issue 67)
>    - slider greyed out on start (issue 69)
>    - Translations displayed correctly (issue 64)
>--> * Packaging changes (byte-compilation, dependencies)
>this is so generic.
>you might change with "add python3-gi build dependency, needed for foo
>add some version constraints, needed for foo/bar
>2) control:
>-               dh-python,
>+               dh-python (>= 1.20130903),
>this change makes me think you didn't start from the unstable version on your packaging changes.
>the version of dependencies are already satisfied in old-old-stable, so you can just remove them.
>the add of python3-gi has a rationale?
>(I'm fine with new dependencies, as long as they are needded and not a leftover of a bad packaging change)
>3) copyright:
>-Copyright: 2015 fossfreedom <foss.freedom@gmail.com>
>+Copyright: 2015 David Mohammed <foss.freedom@gmail.com>
>maybe you might want to change in
>Copyright: 2015-2016 David Mohammed <foss.freedom@gmail.com>
>about the postrm/prerm scripts, I'm not sure they are worth the effort.
>"python3 -m compileall /usr/lib/rhythmbox/plugins/alternative-toolbar/ > /dev/null 2>&1"
>you compile the python stuff in the postrm script?
>so when a user removes the package the files are compiled?
>maybe it was postinstall? :)
>in fact adeguate still complains
>let me know when you have addressed the above.

--- End Message ---

Reply to: