Bug#810529: RFS: moc/1:2.6.0~svn-r2788-1
* Mattia Rizzolo <firstname.lastname@example.org> [2016-01-09 15:53 +0000]:
> ok, some stuff I'd like to see changeed/explained before uploading:
> * debian/rules:
> + dh_strip --no-ddebs => WHY ?! so much work has been done to get
> automatically built debug packages, why you wouldn't want them?
I don't want to bother pool space with 0.5M per each arch. I am not
aware of an useful case where debugging symbols where needed running
moc the last ten years or so.
> + DPKG_EXPORT_BUILDFLAGS and the include are not needed in dh compat 9
> + dh_shlibdeps -- --warnings=0 => is there a particular reason to use
> --warnings=0 ? e.g. is it so uselessly noisy otherwise?
Indeed, it is uselessly noisy otherwise.
> * debian/changelog:
> + can you move the closes: to the line that tells about the ftbfs with
> ffmpeg 2.9? after all, that bug is about the ftbfs, not about
> having a newer upstream
> * debian/moc.menu:
> + can you consider removing it? after the last CTTE deliberation the
> menu system is considered deprecated.
> * debian/copyright:
> + we are in 2016 ;)
Of course yes :) Corrected.
> furthermore, be aware that even if added that `DEB_BUILD_MAINT_OPTIONS =
> hardening=+all`, blhc still complains about 'LDFLAGS missing
> (-Wl,-z,now)' and 'CFLAGS missing (-fPIE)' (and even there is a 'LDFLAGS
> missing (-fPIE -pie -Wl,-z,now)'. and indeed you have several
> hardening-no-fortify-functions (which you already have, anyway).
Well, running blhc without an option gives no output but with --all
option. Hmm, at this point my skills stuck..... I even know that
lintian -iI --pedantic gives a warning and discussed that with
upstream but there was no effort, though.
Thanks for the review.
Numeric stability is probably not all that
important when you're guessing;-)