[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#810529: RFS: moc/1:2.6.0~svn-r2788-1

control: owner -1 !
control: tag -1 moreinfo

On Sat, Jan 09, 2016 at 04:07:20PM +0100, Elimar Riesebieter wrote:
> I am looking for a sponsor for my package "moc" as my main sponsor and uploader
> isn't available at the moment.

yeah, sure :)

> Alternatively, one can download the package with dget using this command:
> dget -x http://mentors.debian.net/debian/pool/main/m/moc/moc_2.6.0~svn-r2788-1.dsc

ok, some stuff I'd like to see changeed/explained before uploading:

* debian/rules:
  + dh_strip --no-ddebs => WHY ?!  so much work has been done to get
    automatically built debug packages, why you wouldn't want them?
  + DPKG_EXPORT_BUILDFLAGS and the include are not needed in dh compat 9
  + dh_shlibdeps -- --warnings=0 => is there a particular reason to use
    --warnings=0 ?  e.g. is it so uselessly noisy otherwise?
* debian/changelog:
  + can you move the closes: to the line that tells about the ftbfs with
    ffmpeg 2.9?  after all, that bug is about the ftbfs, not about
    having a newer upstream
* debian/moc.menu:
  + can you consider removing it?  after the last CTTE deliberation the
    menu system is considered deprecated.
* debian/copyright:
  + we are in 2016 ;)

furthermore, be aware that even if added that `DEB_BUILD_MAINT_OPTIONS =
hardening=+all`, blhc still complains about 'LDFLAGS missing
(-Wl,-z,now)' and 'CFLAGS missing (-fPIE)' (and even there is a 'LDFLAGS
missing (-fPIE -pie -Wl,-z,now)'.  and indeed you have several
hardening-no-fortify-functions (which you already have, anyway).

                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply to: