[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#809272: RFS: pygithub/1.26.0-1 ITP

* Mattia Rizzolo <mattia@debian.org> [2016-01-05 16:34:13+0000]
> On Tue, Jan 05, 2016 at 06:51:01PM +0300, Dmitry Bogatov wrote:
> > > * please consider handing a spellchecked to upstream, looks like there
> > >   are some typos
> > 
> > Fix spelling in comments or disabled and not-installed tests? Are you sure?
> just try runnning `codespell --quiet-level=3`...  and yes, most of them
> are in the tests.

Do not understand. Why bother about spelling, which is not user-visible?

> > Uploaded new version on mentors.
> umh.
> I personally wouldn't install the readme as a changelog, but if you
> really want to, please use dh_installchangelog instead (which compress
> it, as per policy):

It actually contains changelog.

> override_dh_installchangelogs:
> 	dh_installchangelogs README.md
> to fit both of the tastes maybe to use the -k flag of it?

Nice to know. Will rewrite and reupload.
> but anyway, I'd like to wait some more for comments from other people
> about that Provides :)

Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Attachment: signature.asc
Description: Digital signature

Reply to: