On Monday, December 28 2015, Ben Finney wrote: > Sergio Durigan Junior <sergiodj@sergiodj.net> writes: > >> On Monday, December 28 2015, Ben Finney wrote: >> > If you want a suffix indicating “later than 0.5.11”, a conventional >> > separator to use is “+”. So, “0.5.11+ds1”. >> >> I was afraid you were going to say that... >> >> My first attempt was to use '+ds1' instead of '~ds1', but unfortunately >> Midori's build system/cmake (I still don't know which one) has a problem >> with that. I cannot perform a successful build if there is a '+' in the >> source directory name. > > That is IMO a flaw in the build system, then. Are you able to fix it? Yes, it is a bug in the build system. I may be able to fix it, but it does not seem trivial. I spent some time investigating and still don't know if the culprit is Midori's cmake scripts or cmake itself. > Generally, I would think the build system should not care at all about > what directory it finds itself in; all operations on the code base > should be relative to the top directory, so the name of that directory > should never make any difference. Yes, that is how things should be. GNU Autotools does not have/prevents this problem. > Is there some special reason why the build system needs to care about > the name of the directory containing the code base? If not, remove that > limitation and submit it as a patch upstream; and, meanwhile, apply it > as a patch to the Debian source package. No special reason; as I said, it is a bug and should be fixed. If I had a fix before, I wouldn't have sent this e-mail in the first place: instead, I would have have done exactly what you proposed above. But I could not fix the bug, and since I don't have much time these days, I decided to ask for help here. Gianfranco's solution worked, and I went ahead and pushed the new package. I only saw your e-mail after I did that, so I apologize for not continuing the discussion with you. This '-ds1' prefix should be needed only for this revision (0.5.11-ds1); as soon as Midori 0.5.12 is released I will go back to the normal versioning scheme. I myself also prefer to use '+' instead of '-', just to be clear. Anyway, I appreciate your help and your explanations. I learned some important lessons with this mistake, and I don't intend to repeat it :-). Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
Attachment:
signature.asc
Description: PGP signature