Ok, there is a new version at mentors, available via
dget -x http://mentors.debian.net/debian/pool/main/c/classified-ads/classified-ads_0.06-1.dsc
Changes compared to previous version are:
- dpkg-dev build-dependency gone
- Original High-res bitmaps again included, with semi-automatic conversion
method. xcf2png could not do resize so imagemagick is used, from a
included makefile. Bitmap conversion needs to be initiated manually,
dpkg-buildpackage uses files already in .orig.tar if manual update
is not triggered first.
- d/changelog Commit message shortened, timestamp closer to present time.
- d/control debhelper version dependency now >9
- Structured d/copyright like this
License: A or B or C
License A:
<Grant + reference to text of A>
License B:
<Grant + Additional text to B + reference to text of B >
License C:
<Grant only as it makes no reference to any external document>
Also removed trailing whitespaces.
- d/rules hardening flag gone
- d/watch not changed, looks like github offers only .zip and
.tar.gz for tarball dl.
- pushed pristine-tar branch to github
In ~/.gbp.conf I have
[DEFAULT]
debian-branch = debian
as I wanted to have the future development in master-branch but hopefully
it won't complicate work of others.
And:
> [net/retrievalengine.cpp:113]: (error) Dereferencing 'connectCandidate'
> after it is deallocated / released
=> Urgh. Gross. Debug build only but still..
> -> In the source code you've mixed tabs and spaces... Maybe you can work
> towards a coherrent coding-style-guidline to ease reading of the code?
> -> configure your editor to remove trailing whitespaces :)
> -> check-all-the-things has also some input for you, eg. codespell
> is a little bit sad and there are warnings from flawfinder regarding
> potential unsafe use of the random number generator.
=> Flawfinder is partly right: the traditional libc6 rand() -routines are
seeded too but not used for anything sensitive. There are uses.
Some flawfingers warnings could be fixed, while they're not outright
errors, they're not nice either, for instance frequent usage of fixed-size
char-arrays just for sake of formatting strings for log-macro..
Lets at least run code-beautifier once, it will structure the text.
"astyle style=attach" at least unifies the indentation and removes
trailing spaces.
Emacs configures the user to remove trailing whitespaces when editing.
Almost always.
--
Antti
Attachment:
message.signed.asc
Description: Message content with signature