Bug#754463: RFS: pdf2htmlex/0.11+ds-1
* Johannes Schauer <j.schauer@email.de>, 2014-07-12, 13:06:
Is the non-minified version used by pdf2htmlEX at runtime at all? I
think it isn't, but I could be wrong. If it's not, then maybe get rid
of the symlink, and drop libjs-pdf from Depends?
Yes it is. You can check that it is used by running the test suite like
this: `( cd obj-*-linux-gnu; ctest -V; )`. You will see that it aborts
because it cannot find compatibility.min.js in ./share. You have to run
the test suite like that because it wrongly shows success even though
the tests fail. I'll have to fix that and report it upstream.
The file share/manifest or /usr/share/pdf2htmlEX/manifest controls what
gets included into the final pdf. It is the "@compatibility.min.js"
line in that file which makes compatibility.min.js be included by the
function HTMLRenderer::embed_file in src/HTMLRenderer/general.cc.
I don't doubt that compatibility.min.js is needed. What I questioned is
whether we ever need compatibility.js in the binary package.
I guess I use the unminified version of compatibility.js until
bug#754533 is resolved.
Sounds good to me.
Who is the copyright holder for the files in debian/? According to the
copyright file it's WANG Lu. :-P
The machine-readable debian/copyright file specification advices against
using “MIT” as the short license name.
Short license name for GPL version 3 or a later version is “GPL-3+”, not
“GPL-3”.
s/On On/On/
IMO information about which files where excluded .orig.tar doesn't
belong in d/copright, especially when they weren't excluded for license
reasons.
Speaking of which, how exactly was the .orig.tar generated?
It would be nice if the TMPDIR environment variable was honoured.
In the build log I see:
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/pdf2htmlex/usr/bin/pdf2htmlEX was not linked against libgunicode.so.3 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/pdf2htmlex/usr/bin/pdf2htmlEX was not linked against libpython2.7.so.1.0 (it uses none of the library's symbols)
It would be nice to get rid of these warnings.
What is default-jre-headless in Build-Depends for?
--
Jakub Wilk
Reply to: