Re: Sponsor for the gtkiostream
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Matt,
I'm not a DD myself, so can't upload your package but I shall give my
review of it, in the hope it can help you to find a sponsor.
It may be worth you filing an RFS bug against the pseudo-package
sponsorship-requests [1] and the standard form for an RFS [2], this
may also increase your chances of finding a sponsor.
> It is actually already packaged, the debian directory is
> distributed with the source code :
> https://sourceforge.net/projects/gtkiostream/
The generally accepted standard is to keep the Debian packaging
separate from the upstream source. I'm not sure what the exact state
would be since you are upstream as well [3]
Reading some old posts on the debian-mentors list it should be
sufficient to just drop the debian directory from the source tarball,
but this would need clarification from someone with more experience
than myself
> By sponsoring this package you will close the following bugs :
>
> Closes: #709641 Closes: #722527
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=722527
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=709641
>
> You will also replace some very old packages of mine with much
> better and newer implementations : Replaces: wsola, mffm-fftw1,
> libaudiomask1 Replaces: wsola-dev, mffm-fftw-dev, libaudiomask-dev
>
As it stands your package wouldn't automatically close these bugs as
they are not closed in the latest changelog entry.
Also as this package is not yet in Debian, you should merge the
changelog entries to the single version being uploaded.
Other Items
- debian/compat - This should be 9
- debian/control - Build-Depends for debhelper should be debhelper (>= 9)
- debian/rules - You can remove the 'boilerplate' comment from here
The package also failed to build for me in an unstable chroot using
pbuilder. I have attached a log showing the build error.
Running lintian against the source package, gives me the follwing:
N: Processing source package gtkiostream (version 1.3.0-1, arch
source) ...
W: gtkiostream source: debhelper-but-no-misc-depends gtkiostream-doc
I: gtkiostream source: debian-watch-file-is-missing
Regards
Daniel Lintott
[1] http://mentors.debian.net/sponsors
[2] http://mentors.debian.net/sponsors/rfs-howto/gtkiostream
[3] https://wiki.debian.org/UpstreamGuide
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQEcBAEBAgAGBQJSfPoeAAoJEMw/9yOWzAkJIeAH/iKAaTaZTzgYqBke7VLdtrrP
E1WXvytLmj1/SBrcmtqB/jk0C44bdIBSo3UQaxf8OqgXZ083TMf3JHDFud79uBgR
h0Q/70HHfUpJew/LCvbgyZTqWOEhINo4TNNdfisOa0fYKTGCb0Eeivr7fO5ZpPK/
hExv0IWPBKItj5R5pUULhsTkw3aImsm36IA20EE+uL7sgFfaDE8d4lKRYbaWuRdm
dYXc+HJ6sD5xw+8dheZf7ZaGVmy+dxvFA2kvCWINYzC3qzRP4GREFU8WUgilPfaU
iAbgtEmqbC29oRlSB83Kwb6ZEE4xedDb4DeegfyGqZvcJ+cAeMzPGqVJYxsq9Mc=
=f9kf
-----END PGP SIGNATURE-----
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -I../include -ImachineGeneratedGtkiostream -I../../src/machineGeneratedGtkiostream -g -O2 -c machineGeneratedGtkiostream/ORBICE.C -fPIC -DPIC -o .libs/libORB_la-ORBICE.o
In file included from machineGeneratedGtkiostream/ORBICE.C:21:0:
machineGeneratedGtkiostream/ORBICE.H:42:9: error: #error Ice version mismatch: an exact match is required for beta generated code
# error Ice version mismatch: an exact match is required for beta generated code
^
machineGeneratedGtkiostream/ORBICE.C:30:9: error: #error Ice version mismatch: an exact match is required for beta generated code
# error Ice version mismatch: an exact match is required for beta generated code
^
machineGeneratedGtkiostream/ORBICE.C: In member function 'virtual void ORB::ORBICE::__writeImpl(IceInternal::BasicStream*) const':
machineGeneratedGtkiostream/ORBICE.C:530:47: error: no matching function for call to 'IceInternal::BasicStream::startWriteSlice(const string&, bool)'
__os->startWriteSlice(ice_staticId(), true);
^
machineGeneratedGtkiostream/ORBICE.C:530:47: note: candidate is:
In file included from /usr/include/Ice/OutgoingAsync.h:24:0,
from /usr/include/Ice/Proxy.h:25,
from machineGeneratedGtkiostream/ORBICE.H:29,
from machineGeneratedGtkiostream/ORBICE.C:21:
/usr/include/Ice/BasicStream.h:330:10: note: void IceInternal::BasicStream::startWriteSlice(const string&, int, bool)
void startWriteSlice(const std::string& typeId, int compactId, bool last)
^
/usr/include/Ice/BasicStream.h:330:10: note: candidate expects 3 arguments, 2 provided
make[3]: *** [libORB_la-ORBICE.lo] Error 1
make[3]: Leaving directory `/tmp/buildd/gtkiostream-1.3.0/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/gtkiostream-1.3.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/gtkiostream-1.3.0'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package
Reply to: