Bug#696782: RFS: sequitur-g2p/0.0.r1668-1 [ITP] -- Grapheme to Phoneme conversion tool

[Jakub Wilk <jwilk@debian.org>]

* Giulio Paci <giuliopaci@gmail.com>, 2013-01-14, 02:32:
> > > http://mentors.debian.net/debian/pool/main/s/sequitur-g2p/sequitur-g2p_0.0.r1668-1.dsc
> > The license has this additional clause:
> >
> > Should a provision of no. 9 and 10 of the GNU General Public License 
> > be invalid or become invalid, a valid provision is deemed to have been 
> > agreed upon which comes closest to what the parties intended 
> > commercially. In any case guarantee/warranty shall be limited to gross 
> > negligent actions or intended actions or fraudulent concealment.
> >
> > Shouldn't that be "11 and 12" instead of "9 and 10"? I can't make 
> > sense of it otherwise...
>
> I asked the author. He explained that the problem was their legal 
> department was worried that the license terms could be changed by third 
> party (i.e., FSF).

This is trivially fixed by including the whole license text in the 
tarball. I don't see how adding extra clauses could help here, even if 
they made sense...

> Our thought is that this clause is there just to say that the software 
> is released under GPL-2, so the reference to 9 and 10 should be right.
>
> Unfortunately the author is not working anymore for the copyright 
> owner, and he cannot change the license. I wrote to the current head of 
> department last week, but I have not received any answer yet.
>
> Do you think the license, as it is, is acceptable?

Well, license with clauses I can't understand is not something 
acceptable for me. But you may want to ask debian-legal@ folks for their 
opinion.

> > lintian4python emits a bunch of tags:
> >
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/bin/sequitur-g2p:46
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/Evaluation.py:34
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/Minimization.py:48
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/SequenceModel.py:37
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/SequiturTool.py:41
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/g2p.py:46
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/misc.py:35
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/sequitur.py:38
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/symbols.py:41
> > w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/tool.py:50

The patch that fixes this is huge, and clearly not maintainable. Please 
make sure this problem is fixed upstream by their next release.

Please also ask them to not include *.pyc files in the tarballs.

The shebang should be fixed before the dh_pysupport call. 
(python-supports looks at shebangs to generate the ${python:Depends} 
substvar.)

--
Jakub Wilk