El lun, 07-01-2013 a las 09:55 +0100, Helmut Grohne escribió: > Please hold back new upstream releases from unstable until after the > freeze and target experimental instead. This would be a small step at > speeding up the wheezy release. Seems reasonable. I was worry by duplicities. Changed to target experimental. > If you change an older changelog entry (1.2.10~pre3-2) please explain > why in the current changelog entry. Sorry, unwanted changes. Reverted. > > * Split libgringotts from gringotts source package again. It's an > > independent library and could be useful in other software. > > This sounds even more inappropriate during the freeze. > > > * debian/copyright: rewrite to machine-readable format. > > It is nice to see machine readability get more adoption. However in this > case human readability seems to have suffered. Your license paragraphs > are very short. Specifically they mention "GPL-2+" which suggests the > "or any later version" which is not included in your license paragraph. > Please either drop the "+" or include the "or any later version" for > consistency. > > Indeed without "or any later version" the (binary) package is not > redistributable, because GPL-2 and GPL-3 are incompatible[1]. This is > why I tagged the bug moreinfo. Please remove the tag after fixing this > issue. I have doubts here. I changed to GPL2+ to be compatible but previous package (Wesley's) was released as GPL3 and I'm not sure if I can relicense debian files as GPL2+. Completed the license paragraph, too. > > * debian/rules: rewrite to get rid of unnecessary dependencies and add > > some hardening flags. > > This sounds confusing given that you actually disabled hardening: > > gringotts-1.2.10/debian/rules: > | # Errors compiling with hardening > | #CFLAGS:=$(shell dpkg-buildflags --get CFLAGS) $(CPPFLAGS) > > What is the problem with hardening? Maybe it can be resolved? True, a forgotten entry ... At that time I couldn't fix it but today I looked at it more deeply and I have created a patch to allow compile with hardening build flags. > Please clean up the following patch. It contains more TODO-ish stuff. > > gringotts-1.2.10/debian/patches/fix-mkinstalldirs-old-gettext.patch: > | Description: <short summary of the patch> > | TODO: Put a short summary on the line above and replace this paragraph > | with a longer explanation of this change. Complete the meta-information > | with other relevant fields (see below for details). To make it easier, the > | information below has been extracted from the changelog. Adjust it or drop > | it. > | . Done. > The following boilerplate can likely be removed: > > gringotts-1.2.10/debian/rules: > | # Sample debian/rules that uses debhelper. > | # This file was originally written by Joey Hess and Craig Small. > | # As a special exception, when this file is copied by dh-make into a > | # dh-make output file, you may use that output file without restriction. > | # This special exception was added by Craig Small in version 0.37 of dh-make. Cleaned, too. > Helmut Thank you very much for your comments, they are very welcome. Re-uploaded to mentors. Regards
Attachment:
signature.asc
Description: This is a digitally signed message part