[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#695366: RFS: gringotts/1.2.10-1

Control: tag -1 + moreinfo

On Fri, Dec 07, 2012 at 04:53:26PM +0100, Jose G. López wrote:
> gringotts (1.2.10-1) unstable; urgency=low
>   * New upstream release.

Please hold back new upstream releases from unstable until after the
freeze and target experimental instead. This would be a small step at
speeding up the wheezy release.

If you change an older changelog entry (1.2.10~pre3-2) please explain
why in the current changelog entry.

>   * Split libgringotts from gringotts source package again. It's an
>     independent library and could be useful in other software.

This sounds even more inappropriate during the freeze.

>   * debian/copyright: rewrite to machine-readable format.

It is nice to see machine readability get more adoption. However in this
case human readability seems to have suffered. Your license paragraphs
are very short. Specifically they mention "GPL-2+" which suggests the
"or any later version" which is not included in your license paragraph.
Please either drop the "+" or include the "or any later version" for

Indeed without "or any later version" the (binary) package is not
redistributable, because GPL-2 and GPL-3 are incompatible[1]. This is
why I tagged the bug moreinfo. Please remove the tag after fixing this

>   * debian/rules: rewrite to get rid of unnecessary dependencies and add
> some hardening flags.

This sounds confusing given that you actually disabled hardening:

| # Errors compiling with hardening
| #CFLAGS:=$(shell dpkg-buildflags --get CFLAGS) $(CPPFLAGS)

What is the problem with hardening? Maybe it can be resolved?

Please clean up the following patch. It contains more TODO-ish stuff.

| Description: <short summary of the patch>
|  TODO: Put a short summary on the line above and replace this paragraph
|  with a longer explanation of this change. Complete the meta-information
|  with other relevant fields (see below for details). To make it easier, the
|  information below has been extracted from the changelog. Adjust it or drop
|  it.
|  .

The following boilerplate can likely be removed:

| # Sample debian/rules that uses debhelper.
| # This file was originally written by Joey Hess and Craig Small.
| # As a special exception, when this file is copied by dh-make into a
| # dh-make output file, you may use that output file without restriction.
| # This special exception was added by Craig Small in version 0.37 of dh-make.


[1] http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility

Reply to: