[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684220: RFS: tinysvm/0.09-1 [ITP] -- SVM trainer and classifier toolkit

Il 26/10/2012 21:52, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2012-10-24, 00:17:
>>> The */TinySVM_wrap.c license:
>>> | This file may be freely redistributed without license or fee provided
>>> | this copyright message remains intact.
>>> doesn't seem particularly free to me, as it doesn't explicitly permit modifications.
>>> Hopefully this could be resolved by rebuilding the wrapper using a SWIG version that is less than 10 years old... The file says:
>>> | Do not make changes to this file unless you know what you are
>>> | doing--modify the SWIG interface file instead.
>>> But where is the interface file? I don't see it included in the tarball.
>> I finally decided to repackage the tarball with files generated by more recent versions of swig.
>> I used an interface file downloaded from https://github.com/shogo82148/TinySVM/.
> The binding should be regenerated at build time. But... are they currently used at all? If not, it might be simpler just to strip them out completely.

I do not know any user of the bindings, but I would prefer to keep at least their sources in the package (I have to repackage the tarball anyway and the bindings sources do
not introduce a large overhead), if it is not a problem to leave the source there and not compiling them.

> In any case, please provide a get-orig-source target.

I have no experience with this target.
I read the description on this page (http://www.debian.org/doc/debian-policy/ch-source.html), but I did not understood what I am supposed to do.
As far as I understood, this target should provide a way to get the sources for the patched upstream tarball.
Anyway the description reports that the target should:
1) download the original source file;
2) recreate the patched source;
3) tar the patched source.

It is possible to implement these steps, but I need some software to do that (e.g., something to retrieve files from upstream and from
https://github.com/shogo82148/TinySVM/ and the same version of swig that I used to recreate the bindings file).
How should I handle these additional dependencies?

On the other hand I am storing the tarball in a git repository using pristine-tar, so it would be easier to get files from git and pristine-tar (I just need to publish the
git repository somewhere).
Can I rely on git and pristine-tar to implement this target (this will provide patched sources in a more reliable way)?

I guess that the three steps above are suggested because they suppose that newer versions of the upstream tarball will continue to pose the same problem. Are those three
steps mandatory? Given the source of the issue (very old swig version used to generate some file) I think it is unlikely that this issue will be present in future releases.


Reply to: