[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#657428: RFS: surf -- simple web browser (QA upload)

* Vasudev Kamath <kamathvasudev@gmail.com>, 2012-01-27, 23:49:
+ Reduced the update-alternative priority to 30 as per request from user to the previous maintainer
Hmm. Was there a bug report about that?
No previous maintainer Kai forwarded mail to me as I had adopted his dwm package. I asked the reporter to raise a bug but he didn't do that. So what do you suggest me to do for this? Shall I raise a bug or its not required?.
Well, I wanted to have some insight into what problem we're trying to solve here. Having it documented somewhere (preferably in a bug report) would be nice.
Done reported it as bugs by including mail content which I got and added closes in changelog

For the record, the bug number is #657646.

As I commented there, I'm not convinced that reducing priority is necessary. That said, it won't do (much) harm either, so I don't really mind.

Please consider applying the attached patch, which fixes some minor whitespace issues.

I see you added patch header to debian/patches/X11.diff, which is great, but if it was meant to follow DEP-3: - "Last-Updated" should be spelled "Last-Update" and should use YYYY-MM-DD format.
- You could add Bug-Debian field.

Oh, my remark about Last-Update(ed) also applies to dpkg-buildflags.patch. :)

Jakub Wilk
diff --git a/debian/changelog b/debian/changelog
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,8 +14,9 @@
   * Added patch to config.mk to make it honour {C,CPP,LD}FLAGS environment
   * debian/rules:
-    + Export {C,CPP,LD} FLAGS environment variables for introducing
+    + Export {C,CPP,LD}FLAGS environment variables for introducing
  -- Vasudev Kamath <kamathvasudev@gmail.com>  Fri, 27 Jan 2012 23:22:17 +0530
 surf (0.4.1-4.1) unstable; urgency=low
diff --git a/debian/control b/debian/control
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,7 @@
 Source: surf
 Section: web
 Priority: optional
-Build-Depends: debhelper (>= 8), libgtk2.0-dev, libwebkit-dev,dpkg-dev (>= 1.16.1)
+Build-Depends: debhelper (>= 8), libgtk2.0-dev, libwebkit-dev, dpkg-dev (>= 1.16.1)
 Standards-Version: 3.9.2
 Maintainer: Debian QA Group <packages@qa.debian.org>
 Homepage: http://surf.suckless.org

Reply to: