[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: xiterm+thai

On Thu, Jan 5, 2012 at 7:16 PM, Neutron Soutmun wrote:

> I am looking for a sponsor for new version 1.10-1 (new upstream release)
> of my package "xiterm+thai".

Uploaded, thanks for your contribution.

Some things you might want to look at:

The package isn't particularly popular according to popcon, if you
know people using it on Debian you might want to suggest to them that
they install the popularity-contest package and enable the cron job:


The debtags site says there is a missing tag, you might want to add
it, audit the tags and update them:


A warning from configure:

config.status: WARNING:  'Make.common.in' seems to ignore the
--datarootdir setting

Some warnings from desktop-file-validate:

debian/xiterm+thai.desktop: error: value "1.07" for key "Version" in
group "Desktop Entry" is not a known version
debian/xiterm+thai.desktop: warning: value "Thai X terminal" for key
"Comment" in group "Desktop Entry" looks redundant with value "Thai X
terminal" of key "Name"
debian/xiterm+thai.desktop: error: (will be fatal in the future):
value "xiterm+thai.png" for key "Icon" in group "Desktop Entry" is an
icon name with an extension, but there should be no extension as
described in the Icon Theme Specification if the value is not an
absolute path
debian/xiterm+thai.desktop: error: value "Application;Utility" for
string list key "Categories" in group "Desktop Entry" does not have a
semicolon (';') as trailing character

Some warnings from cppcheck:

[test/graphics/qplot.c:120]: (error) Resource leak: fd
[src/Xtensions/graphics/command.c:1028]: (error) Resource leak: ptyfd
[src/command.c:1077]: (error) Resource leak: ptyfd
[src/Xtensions/menubar+graphics/command.c:1030]: (error) Resource leak: ptyfd

There are some duplicate files:



Please add a comment to the lintian overrides file explaining why
setgid-binary has been overridden.

How about including some things from debian/ upstream? Maybe inputrc
txiterm txiterm.1 xiterm+thai.desktop?

The maintainer scripts and the txiterm manual page contain a lot of
unnessecary comments.



Reply to: