Re: RFS: gimp-gap: fix FTBFS, libjpeg transition

[Ansgar Burchardt <ansgar@debian.org>]

Hi,

Thibaut Paumard <paumard@users.sourceforge.net> writes:
> gimp-gap   - animation package for the GIMP
> http://mentors.debian.net/debian/pool/main/g/gimp-gap/gimp-gap_2.6.0+dfsg-2.dsc

The package still fails to build in a current unstable chroot:

--8<---------------cut here---------------start------------->8---
gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../libwavplayclient -I../libgapbase -I../libgapvidapi   -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gimp-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/gio-unix-2.0/   -I/usr/include -DGAPLIBDIR=\""/usr/lib/gimp-gap-2.6"\" -DLOCALEDIR=\""/usr/share/locale"\" -DGIMP_DISABLE_DEPRECATED  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -fPIC -c gap_fmac_name.c
gap_arr_dialog.c: In function 'gap_arr_msg_win':
gap_arr_dialog.c:1862:10: error: format not a string literal and no format arguments [-Werror=format-security]
gap_pview_da.c: In function 'p_pixmap_data_destructor':
gap_pview_da.c:1327:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
gap_pview_da.c: In function 'gap_pview_get_repaint_thdata':
gap_pview_da.c:1431:7: warning: variable 'rowstride' set but not used [-Wunused-but-set-variable]
gap_pview_da.c:1430:7: warning: variable 'bits_per_sample' set but not used [-Wunused-but-set-variable]
gap_lib.c: In function 'p_lib_save_named_image_1':
gap_lib.c:2135:47: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
gap_onion_base.c: In function 'gap_onion_base_image_duplicate':
gap_onion_base.c:679:17: warning: unused variable 'l_has_onion' [-Wunused-variable]
gap_lib.c: In function 'gap_lib_load_image':
gap_lib.c:2538:10: warning: variable 'l_rc' set but not used [-Wunused-but-set-variable]
gap_vin.c: In function 'gap_vin_get_all_keylist':
gap_vin.c:154:24: warning: variable 'txf_ptr_root' set but not used [-Wunused-but-set-variable]
cc1: some warnings being treated as errors

make[3]: *** [gap_arr_dialog.o] Error 1
make[3]: *** Waiting for unfinished jobs....
--8<---------------cut here---------------end--------------->8---

Please consider removing debian/control.in as you seem not to use it and
it contains outdated information.

There is no need to include changelog entries from Ubuntu.  If you
choose to include them, please exclude uploads done to rebuild the
package (those including a "*build1" or similar in the version).

I do not find timestamps in quilt patches to be particular useful,
turing them off means less noise in a debdiff.  Please consider doing
so, see QUILT_NO_DIFF_TIMESTAMPS, QUILT_NO_DIFF_INDEX in quilt(1).

Regards,
Ansgar